[PATCH] drm/schedular: fix the warning in drm_sched_job_done

[Khatri, Sunil]

On 4/17/2025 3:01 PM, Tvrtko Ursulin wrote:
>
> [Added Philipp and Danilo to cc.]
>
> On 17/04/2025 10:25, Sunil Khatri wrote:
>> Fix the below warning.
>> scheduler/sched_main.c:397: warning: Function parameter or struct 
>> member 'result' not described in 'drm_sched_job_done'
>>
>> Signed-off-by: Sunil Khatri <sunil.khatri at amd.com>
>> ---
>>   drivers/gpu/drm/scheduler/sched_main.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/scheduler/sched_main.c 
>> b/drivers/gpu/drm/scheduler/sched_main.c
>> index bfea608a7106..2b5cf2bdf900 100644
>> --- a/drivers/gpu/drm/scheduler/sched_main.c
>> +++ b/drivers/gpu/drm/scheduler/sched_main.c
>> @@ -390,6 +390,7 @@ static void drm_sched_run_free_queue(struct 
>> drm_gpu_scheduler *sched)
>>   /**
>>    * drm_sched_job_done - complete a job
>>    * @s_job: pointer to the job which is done
>> + * @result: passed dma fence error
>>    *
>>    * Finish the job's fence and wake up the worker thread.
>>    */
>
> s/drm\/schedular:/drm\/sched:/
Noted
>
> With that:
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin at igalia.com>
>
> Optionally, "passed dma fence error" could perhaps be improved to say 
> something like "Error code to set on the scheduler fence".
Noted, Thanks a lot.
>
> Regards,
>
> Tvrtko
>