[PATCH] drm/amd: Replace calls to kmalloc()+memcpy()+free(old) with krealloc()

Nikola Z. Ivanov zlatistiv at gmail.com
Sat Apr 19 12:40:09 UTC 2025


Possibly gets rid of some redundant calls to memcpy.

Signed-off-by: Nikola Z. Ivanov <zlatistiv at gmail.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
index 56bc2644e492..7ffd0d8f9897 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
@@ -146,7 +146,7 @@ static void amdgpu_dm_plane_add_modifier(uint64_t **mods, uint64_t *size, uint64
 
 	if (*cap - *size < 1) {
 		uint64_t new_cap = *cap * 2;
-		uint64_t *new_mods = kmalloc(new_cap * sizeof(uint64_t), GFP_KERNEL);
+		uint64_t *new_mods = krealloc(*mods, new_cap * sizeof(uint64_t), GFP_KERNEL);
 
 		if (!new_mods) {
 			kfree(*mods);
@@ -154,8 +154,6 @@ static void amdgpu_dm_plane_add_modifier(uint64_t **mods, uint64_t *size, uint64
 			return;
 		}
 
-		memcpy(new_mods, *mods, sizeof(uint64_t) * *size);
-		kfree(*mods);
 		*mods = new_mods;
 		*cap = new_cap;
 	}
-- 
2.49.0



More information about the amd-gfx mailing list