[PATCH RESEND] drm/amdgpu: Remove redundant return value checks for amdgpu_ras_error_data_init
kernel test robot
lkp at intel.com
Tue Apr 22 11:10:24 UTC 2025
Hi Wentao,
kernel test robot noticed the following build errors:
[auto build test ERROR on drm-exynos/exynos-drm-next]
[also build test ERROR on linus/master v6.15-rc3 next-20250417]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Wentao-Liang/drm-amdgpu-Remove-redundant-return-value-checks-for-amdgpu_ras_error_data_init/20250422-153759
base: https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git exynos-drm-next
patch link: https://lore.kernel.org/r/20250422073505.2378-1-vulab%40iscas.ac.cn
patch subject: [PATCH RESEND] drm/amdgpu: Remove redundant return value checks for amdgpu_ras_error_data_init
config: i386-buildonly-randconfig-005-20250422 (https://download.01.org/0day-ci/archive/20250422/202504221807.hOSkO5OB-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250422/202504221807.hOSkO5OB-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504221807.hOSkO5OB-lkp@intel.com/
All error/warnings (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:170:6: warning: unused variable 'ret' [-Wunused-variable]
170 | int ret;
| ^~~
>> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:690:44: error: expected ';' after expression
690 | amdgpu_ras_error_data_init(&obj->err_data)
| ^
| ;
1 warning and 1 error generated.
vim +690 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
664
665 /* make one obj and return it. */
666 static struct ras_manager *amdgpu_ras_create_obj(struct amdgpu_device *adev,
667 struct ras_common_if *head)
668 {
669 struct amdgpu_ras *con = amdgpu_ras_get_context(adev);
670 struct ras_manager *obj;
671
672 if (!adev->ras_enabled || !con)
673 return NULL;
674
675 if (head->block >= AMDGPU_RAS_BLOCK_COUNT)
676 return NULL;
677
678 if (head->block == AMDGPU_RAS_BLOCK__MCA) {
679 if (head->sub_block_index >= AMDGPU_RAS_MCA_BLOCK__LAST)
680 return NULL;
681
682 obj = &con->objs[AMDGPU_RAS_BLOCK__LAST + head->sub_block_index];
683 } else
684 obj = &con->objs[head->block];
685
686 /* already exist. return obj? */
687 if (alive_obj(obj))
688 return NULL;
689
> 690 amdgpu_ras_error_data_init(&obj->err_data)
691
692 obj->head = *head;
693 obj->adev = adev;
694 list_add(&obj->node, &con->head);
695 get_obj(obj);
696
697 return obj;
698 }
699
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the amd-gfx
mailing list