[PATCH v4 0/3] drm/amd/display: Stop control flow if the divisior is zero
Mingcong Bai
jeffbai at aosc.io
Wed Apr 23 03:48:14 UTC 2025
Hi all,
在 2025/1/14 21:28, Tiezhu Yang 写道:
> As far as I can tell, with the current existing macro definitions, there
> is no better way to do the minimal and proper changes to stop the control
> flow if the divisior is zero.
>
> In order to keep the current ability for the aim of debugging and avoid
> printing the warning message twice, it is better to only use ASSERT_BUG()
> and SPL_ASSERT_BUG() directly after doing the following two steps:
>
> (1) Add ASSERT_BUG() macro definition
> (2) Add SPL_ASSERT_BUG() macro definition
>
> This version is based on 6.13-rc7, tested on x86 and LoongArch.
>
> Tiezhu Yang (3):
> drm/amd/display: Add ASSERT_BUG() macro definition
> drm/amd/display: Add SPL_ASSERT_BUG() macro definition
> drm/amd/display: Harden callers of division functions
>
> drivers/gpu/drm/amd/display/dc/basics/fixpt31_32.c | 2 +-
> drivers/gpu/drm/amd/display/dc/os_types.h | 7 +++++++
> drivers/gpu/drm/amd/display/dc/spl/spl_debug.h | 11 +++++++++++
> drivers/gpu/drm/amd/display/dc/spl/spl_fixpt31_32.c | 2 +-
> 4 files changed, 20 insertions(+), 2 deletions(-)
>
Gentle ping on this series...
Harry and Huacai, can you please take a look at this updated series
(since you have both provided comments on previous revisions?), thank you!
Best Regards,
Mingcong Bai
More information about the amd-gfx
mailing list