[PATCH 4/8] drm/amdgpu/mes11: add support for setting gang submit

[Liang, Prike]

[Public]

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Saturday, April 26, 2025 2:41 AM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: [PATCH 4/8] drm/amdgpu/mes11: add support for setting gang submit
>
> Enable a primary and secondary queue that schedule together.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> index 8a31bd81bcb9d..df4aa6ad6a29e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> @@ -783,6 +783,27 @@ static int mes_v11_0_reset_hw_queue(struct
> amdgpu_mes *mes,
>                       offsetof(union MESAPI__RESET, api_status));  }
>
> +static int mes_v11_0_set_gang_submit(struct amdgpu_mes *mes,
> +                                  struct mes_set_gang_submit_input *input) {
> +     union MESAPI__SET_GANG_SUBMIT mes_gang_submit_pkt;
> +
> +     memset(&mes_gang_submit_pkt, 0, sizeof(mes_gang_submit_pkt));
> +
> +     mes_gang_submit_pkt.header.type = MES_API_TYPE_SCHEDULER;
> +     mes_gang_submit_pkt.header.opcode =
> MES_SCH_API_SET_GANG_SUBMIT;
> +     mes_gang_submit_pkt.header.dwsize = API_FRAME_SIZE_IN_DWORDS;
> +
> +     mes_gang_submit_pkt.set_gang_submit.gang_context_addr =
> +             input->primary_gang_context_addr;
> +     mes_gang_submit_pkt.set_gang_submit.slave_gang_context_addr =
> +             input->secondary_gang_context_addr;
> +
> +     return mes_v11_0_submit_pkt_and_poll_completion(mes,
> +                     &mes_gang_submit_pkt, sizeof(mes_gang_submit_pkt),
> +                     offsetof(union MESAPI__RESET, api_status)); }
> +
Please use the MESAPI__SET_GANG_SUBMIT type to get the API status.
With that fix, the patch is Reviewed-by: Prike Liang <Prike.Liang at amd.com>

>  static const struct amdgpu_mes_funcs mes_v11_0_funcs = {
>       .add_hw_queue = mes_v11_0_add_hw_queue,
>       .remove_hw_queue = mes_v11_0_remove_hw_queue, @@ -792,6 +813,7
> @@ static const struct amdgpu_mes_funcs mes_v11_0_funcs = {
>       .resume_gang = mes_v11_0_resume_gang,
>       .misc_op = mes_v11_0_misc_op,
>       .reset_hw_queue = mes_v11_0_reset_hw_queue,
> +     .set_gang_submit = mes_v11_0_set_gang_submit,
>  };
>
>  static int mes_v11_0_allocate_ucode_buffer(struct amdgpu_device *adev,
> --
> 2.49.0