[PATCH 2/2] drm/amdgpu/mes12: use AMDGPU_MES_SCHED_PIPE for reset queues

Alex Deucher alexdeucher at gmail.com
Tue Apr 29 19:21:35 UTC 2025


Will rework this patch.

On Tue, Apr 29, 2025 at 3:14 PM Alex Deucher <alexander.deucher at amd.com> wrote:
>
> We should use the MES_SCHED_PIPE for everything queue related.
>
> Cc: Michael Chen <Michael.Chen at amd.com>
> Cc: Shaoyun Liu <Shaoyun.Liu at amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mes_v12_0.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> index 83136fcbd50ff..e0dbce5976d50 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v12_0.c
> @@ -828,7 +828,6 @@ static int mes_v12_0_reset_hw_queue(struct amdgpu_mes *mes,
>                                     struct mes_reset_queue_input *input)
>  {
>         union MESAPI__RESET mes_reset_queue_pkt;
> -       int pipe;
>
>         if (input->use_mmio)
>                 return mes_v12_0_reset_queue_mmio(mes, input->queue_type,
> @@ -857,12 +856,7 @@ static int mes_v12_0_reset_hw_queue(struct amdgpu_mes *mes,
>                 mes_reset_queue_pkt.doorbell_offset = input->doorbell_offset;
>         }
>
> -       if (mes->adev->enable_uni_mes)
> -               pipe = AMDGPU_MES_KIQ_PIPE;
> -       else
> -               pipe = AMDGPU_MES_SCHED_PIPE;
> -
> -       return mes_v12_0_submit_pkt_and_poll_completion(mes, pipe,
> +       return mes_v12_0_submit_pkt_and_poll_completion(mes, AMDGPU_MES_SCHED_PIPE,
>                         &mes_reset_queue_pkt, sizeof(mes_reset_queue_pkt),
>                         offsetof(union MESAPI__RESET, api_status));
>  }
> --
> 2.49.0
>


More information about the amd-gfx mailing list