[PATCH] drm/amdgpu: keep job->vm in amdgpu_job_prepare_job

[Christian König]

On 23.07.25 11:06, YuanShang wrote:
> job->vm is used in function amdgpu_job_run to get the page
> table re-generation counter and decide whether the job should be skipped.

Support for resubmitting jobs was removed, so that code should probably be removed as well.

We should probably move the call to amdgpu_vm_generation() into amdgpu_job_prepare_job() as well.

Regards,
Christian.

> 
> Signed-off-by: YuanShang <YuanShang.Mao at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_job.c | 7 -------
>  1 file changed, 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> index 45febdc2f349..18998343815e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_job.c
> @@ -360,13 +360,6 @@ amdgpu_job_prepare_job(struct drm_sched_job *sched_job,
>  			dev_err(ring->adev->dev, "Error getting VM ID (%d)\n", r);
>  			goto error;
>  		}
> -		/*
> -		 * The VM structure might be released after the VMID is
> -		 * assigned, we had multiple problems with people trying to use
> -		 * the VM pointer so better set it to NULL.
> -		 */
> -		if (!fence)
> -			job->vm = NULL;
>  		return fence;
>  	}
>