Is amdgpu open to converting logging to drm_* functions

[Brahmajit Das]

On 07.08.2025 15:20, Mike Lothian wrote:
> On Thu, 7 Aug 2025 at 14:22, Alex Deucher <alexdeucher at gmail.com> wrote:
> >
> > On Thu, Aug 7, 2025 at 9:13 AM Brahmajit Das <listout at listout.xyz> wrote:
> > >
> > > Hello Alex, Christian,
> > >
> > > I'm a mentee at Linux kernel Bug Fixing Summer 2025. I came across the
> > > TODO list on the kernel doc, and specifically this section[0]. Would
> > > amdgpu be open to this conversion. I saw that before starting it is
> > > recommended to talk with Sean and the relevant maintainer. Hence I'm
> > > emailing you folks.
> >
> > It would be nice to get rid of the old DRM_INFO/ERROR/DEBUG macros and
> > replace them with the dev_ or drm_ replacements.
> >
> > Alex
> >
> > >
> > > I guess you can also refer to this,
> > > https://patchwork.freedesktop.org/patch/msgid/20191219161722.2779994-1-daniel.vetter@ffwll.ch
> > >
> > > [0]:
> > > https://docs.kernel.org/gpu/todo.html#convert-logging-to-drm-functions-with-drm-device-parameter
> > >
> > > --
> > > Regards,
> > > listout
> 
> Pet peve I get random HDR SB messages printed to my dmesg by the following line:
> 
> https://gitlab.freedesktop.org/drm/kernel/-/commit/88694af9e4d1feaf635c23844833960f8958af78#298241cee0e184ade58580011daae827741f9838_3874_3927
> 
> I'm not sure how this is useful, or how someones supposed to realise
> it's from amdgpu either

If we do something like 

-	print_hex_dump(KERN_DEBUG, "HDR SB:", DUMP_PREFIX_NONE, 16, 1, out->sb,
-		       sizeof(out->sb), false);
+	print_hex_dump(KERN_DEBUG, "AMDGPU HDR SB:", DUMP_PREFIX_NONE, 16, 1,
+		       out->sb, sizeof(out->sb), false);

Maybe it will help in understanding that it's coming from AMDGPU
(assuming we are keeping the print_hex_dump).

-- 
Regards,
listout