[PATCH] drm/radeon/r600_cs: clean up of dead code in r600_cs

[Alex Deucher]

Applied.  Thanks!

Alex

On Mon, Aug 11, 2025 at 8:53 AM Christian König
<christian.koenig at amd.com> wrote:
>
> On 11.08.25 11:21, Brahmajit Das wrote:
> > GCC 16 enables -Werror=unused-but-set-variable= which results in build
> > error with the following message.
> >
> > drivers/gpu/drm/radeon/r600_cs.c: In function ‘r600_texture_size’:
> > drivers/gpu/drm/radeon/r600_cs.c:1411:29: error: variable ‘level’ set but not used [-Werror=unused-but-set-variable=]
> >  1411 |         unsigned offset, i, level;
> >       |                             ^~~~~
> > cc1: all warnings being treated as errors
> > make[6]: *** [scripts/Makefile.build:287: drivers/gpu/drm/radeon/r600_cs.o] Error 1
> >
> > level although is set, but in never used in the function
> > r600_texture_size. Thus resulting in dead code and this error getting
> > triggered.
> >
> > Fixes: 60b212f8ddcdb ("drm/radeon: overhaul texture checking. (v3)")
> > Signed-off-by: Brahmajit Das <listout at listout.xyz>
>
> Acked-by: Christian König <christian.koenig at amd.com>
>
> > ---
> >  drivers/gpu/drm/radeon/r600_cs.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/r600_cs.c b/drivers/gpu/drm/radeon/r600_cs.c
> > index ac77d1246b94..811265648a58 100644
> > --- a/drivers/gpu/drm/radeon/r600_cs.c
> > +++ b/drivers/gpu/drm/radeon/r600_cs.c
> > @@ -1408,7 +1408,7 @@ static void r600_texture_size(unsigned nfaces, unsigned blevel, unsigned llevel,
> >                             unsigned block_align, unsigned height_align, unsigned base_align,
> >                             unsigned *l0_size, unsigned *mipmap_size)
> >  {
> > -     unsigned offset, i, level;
> > +     unsigned offset, i;
> >       unsigned width, height, depth, size;
> >       unsigned blocksize;
> >       unsigned nbx, nby;
> > @@ -1420,7 +1420,7 @@ static void r600_texture_size(unsigned nfaces, unsigned blevel, unsigned llevel,
> >       w0 = r600_mip_minify(w0, 0);
> >       h0 = r600_mip_minify(h0, 0);
> >       d0 = r600_mip_minify(d0, 0);
> > -     for(i = 0, offset = 0, level = blevel; i < nlevels; i++, level++) {
> > +     for (i = 0, offset = 0; i < nlevels; i++) {
> >               width = r600_mip_minify(w0, i);
> >               nbx = r600_fmt_get_nblocksx(format, width);
> >
>