[PATCH 5/7] drm/amd/display: Don't warn when missing DCE encoder caps

[Rodrigo Siqueira]

On 07/31, Timur Kristóf wrote:
> On some GPUs the VBIOS just doesn't have encoder caps,
> or maybe not for every encoder.
> 
> This isn't really a problem and it's handled well,
> so let's not litter the logs with it.
> 
> Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> index 4a9d07c31bc5..0c50fe266c8a 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_link_encoder.c
> @@ -896,13 +896,13 @@ void dce110_link_encoder_construct(
>  						enc110->base.id, &bp_cap_info);
>  
>  	/* Override features with DCE-specific values */
> -	if (BP_RESULT_OK == result) {
> +	if (result == BP_RESULT_OK) {
>  		enc110->base.features.flags.bits.IS_HBR2_CAPABLE =
>  				bp_cap_info.DP_HBR2_EN;
>  		enc110->base.features.flags.bits.IS_HBR3_CAPABLE =
>  				bp_cap_info.DP_HBR3_EN;
>  		enc110->base.features.flags.bits.HDMI_6GB_EN = bp_cap_info.HDMI_6GB_EN;
> -	} else {
> +	} else if (result != BP_RESULT_NORECORD) {
>  		DC_LOG_WARNING("%s: Failed to get encoder_cap_info from VBIOS with error code %d!\n",
>  				__func__,
>  				result);
> @@ -1798,13 +1798,13 @@ void dce60_link_encoder_construct(
>  						enc110->base.id, &bp_cap_info);
>  
>  	/* Override features with DCE-specific values */
> -	if (BP_RESULT_OK == result) {
> +	if (result == BP_RESULT_OK) {
>  		enc110->base.features.flags.bits.IS_HBR2_CAPABLE =
>  				bp_cap_info.DP_HBR2_EN;
>  		enc110->base.features.flags.bits.IS_HBR3_CAPABLE =
>  				bp_cap_info.DP_HBR3_EN;
>  		enc110->base.features.flags.bits.HDMI_6GB_EN = bp_cap_info.HDMI_6GB_EN;
> -	} else {
> +	} else if (result != BP_RESULT_NORECORD) {
>  		DC_LOG_WARNING("%s: Failed to get encoder_cap_info from VBIOS with error code %d!\n",
>  				__func__,
>  				result);
> -- 
> 2.50.1
>

Reviewed-by: Rodrigo Siqueira <siqueira at igalia.com> 

-- 
Rodrigo Siqueira