[PATCH V11 07/47] drm/colorop: Add BYPASS property

Alex Hung alex.hung at amd.com
Wed Aug 20 17:57:27 UTC 2025



On 8/19/25 09:15, Sebastian Wick wrote:
>> +	/**
>> +	 * @bypass_property:
>> +	 *
>> +	 * Boolean property to control enablement of the color
>> +	 * operation. Setting bypass to "true" shall always be supported
> This doesn't actually seem to be the case when the patches later in the
> series are to be believed.
> 
> Somewhere else it says
> 
>    The BYPASS property is not mandatory for a colorop, as long as the
>    entire pipeline can get bypassed by setting the COLOR_PIPELINE on a
>    plane to '0'.
> 
> and later there is a "drm/colorop: allow non-bypass colorops" patch.
> 
> So I'm pretty sure this instance here should be adjusted.

Thanks for pointing this out. I will add "Only present if 
DRM_COLOROP_FLAG_ALLOW_BYPASS flag is set" to patch "drm/colorop: allow 
non-bypass colorops" to clarify the impact of new flag.




More information about the amd-gfx mailing list