[PATCH] drm/amdgpu/vcn: drop extra cancel_delayed_work_sync()

Liu, Leo Leo.Liu at amd.com
Thu Aug 21 14:56:22 UTC 2025


[AMD Official Use Only - AMD Internal Distribution Only]

Looks reasonable to me, the patch is:
Reviewed-by: Leo Liu <leo.liu at amd.com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: August 13, 2025 3:37 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> Subject: [PATCH] drm/amdgpu/vcn: drop extra cancel_delayed_work_sync()
>
> We already call this in the hw_fini() methods for all VCN instances, so no need
> to call it again in amdgpu_vcn_suspend().
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> index 9a76e11d1c184..fd8ebf4b5a824 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vcn.c
> @@ -357,8 +357,6 @@ int amdgpu_vcn_suspend(struct amdgpu_device
> *adev, int i)
>       if (adev->vcn.harvest_config & (1 << i))
>               return 0;
>
> -     cancel_delayed_work_sync(&adev->vcn.inst[i].idle_work);
> -
>       /* err_event_athub and dpc recovery will corrupt VCPU buffer, so we
> need to
>        * restore fw data and clear buffer in amdgpu_vcn_resume() */
>       if (in_ras_intr || adev->pcie_reset_ctx.in_link_reset)
> --
> 2.50.1



More information about the amd-gfx mailing list