[v3 4/5] drm/amd/pm: Update SMU v13.0.6 PPT caps initialization

[Lazar, Lijo]

[Public]

Hi Jesse,

As far as I know, program 5 IP version is 13.0.14. Probably you meant 13.0.12 is not ready.

Thanks,
Lijo
________________________________
From: Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>
Sent: Friday, August 22, 2025 7:03:05 AM
To: Lazar, Lijo <Lijo.Lazar at amd.com>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Liu, Leo <Leo.Liu at amd.com>; Jiang, Sonny <Sonny.Jiang at amd.com>
Subject: RE: [v3 4/5] drm/amd/pm: Update SMU v13.0.6 PPT caps initialization

[AMD Official Use Only - AMD Internal Distribution Only]

-----Original Message-----
From: Lazar, Lijo <Lijo.Lazar at amd.com>
Sent: Thursday, August 21, 2025 11:45 PM
To: Zhang, Jesse(Jie) <Jesse.Zhang at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Koenig, Christian <Christian.Koenig at amd.com>; Liu, Leo <Leo.Liu at amd.com>; Jiang, Sonny <Sonny.Jiang at amd.com>
Subject: Re: [v3 4/5] drm/amd/pm: Update SMU v13.0.6 PPT caps initialization



On 8/20/2025 8:33 AM, Jesse.Zhang wrote:
> Update the conditions for setting the SMU vcn reset caps in the SMU
> v13.0.6 PPT initialization function. Specifically:
>
> - Add support for VCN reset capability for firmware versions 0x00558200 and
>   above when the program version is 0.
> - Add support for VCN reset capability for firmware versions 0x05551800 and
>   above when the program version is 5.
>
> Signed-off-by: Jesse Zhang <Jesse.Zhang at amd.com>
> Acked-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 627a8188d868..9306bfe808e4 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -437,7 +437,9 @@ static void smu_v13_0_6_init_caps(struct smu_context *smu)
>           ((pgm == 4) && (fw_ver >= 0x4557000)))
>               smu_v13_0_6_cap_set(smu, SMU_CAP(SDMA_RESET));
>
> -     if ((pgm == 4) && (fw_ver >= 0x04557100))
> +     if (((pgm == 0) && (fw_ver >= 0x00558200)) ||
> +         ((pgm == 4) && (fw_ver >= 0x04557100)) ||
> +         ((pgm == 5) && (fw_ver >= 0x05551800)))

pgm = 5 should be under smu_v13_0_14_init_caps().
 No, Pgm 0, 4, and 5 are all 13.0.6.
13.0.14 is not ready yet and is being tested.

Thanks
Jesse

Thanks,
Lijo

>               smu_v13_0_6_cap_set(smu, SMU_CAP(VCN_RESET));  }
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20250822/85ccbb8a/attachment.htm>