[RFC PATCH 4/7] drm/amdgpu: Add mmio_remap fields to amdgpu_device

[Christian König]

On 20.08.25 13:32, Srinivasan Shanmugam wrote:
> Add bookkeeping for the remap page to struct amdgpu_device:
> 
> * mmio_remap_bo (singleton BO)
> * mmio_remap_base, mmio_remap_barsz (register BAR base/size)
> * mmio_remap_offset (BAR-relative offset of the remap page)
> * mmio_remap_size (PAGE_SIZE)
> 
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index ddd472e56f69..6c477596617b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1038,6 +1038,13 @@ struct amdgpu_device {
>  	amdgpu_block_wreg_t		audio_endpt_wreg;
>  	struct amdgpu_doorbell		doorbell;
>  
> +	/* ===== MMIO remap (HDP flush) bookkeeping ===== */

Please don't use === for comments. Rather make that proper kerneldoc.

> +	struct amdgpu_bo		*mmio_remap_bo;   /* singleton BO */
> +	resource_size_t 		 mmio_remap_base;  /* REG BAR bus base */
> +	resource_size_t 		 mmio_remap_barsz; /* REG BAR size */
> +	resource_size_t 		 mmio_remap_offset;/* BAR-relative offset of remap page */
> +	resource_size_t 		 mmio_remap_size;  /* always PAGE_SIZE */

And no comment after members please, see kerneldoc for proper style.

Thanks,
Christian.

> +
>  	/* clock/pll info */
>  	struct amdgpu_clock            clock;
>