[PATCH v3 0/3] drm/sched: Job queue peek/pop helpers and struct job re-order

Tvrtko Ursulin tvrtko.ursulin at igalia.com
Fri Feb 7 10:13:16 UTC 2025


On 06/02/2025 16:58, Danilo Krummrich wrote:
> On 2/6/25 5:40 PM, Tvrtko Ursulin wrote:
>> Lets add some helpers for peeking and popping from the job queue which 
>> allows us
>> to re-order the fields in struct drm_sched_job and remove one hole.
> 
> I think you forgot to add the dri-devel list.
> 
> Can't fetch patches with b4. :(

Hmm I probably blundered with git send-email --identity. Will re-send 
after we close on opens from 1/3.

Regards,

Tvrtko

>> v2:
>>   * Add header file for internal scheduler API.
>>   * Add helper for peeking too. (Danilo)
>>   * Add (temporary?) drm_sched_cancel_all_jobs() helper to replace amdgpu
>>     amdgpu_job_stop_all_jobs_on_sched().
>>
>> v3:
>>   * Settle for a copy of __drm_sched_entity_queue_pop in amdgpu for now.
>>
>> Cc: Christian König <christian.koenig at amd.com>
>> Cc: Danilo Krummrich <dakr at kernel.org>
>> Cc: Matthew Brost <matthew.brost at intel.com>
>> Cc: Philipp Stanner <phasta at kernel.org>
>>
>> Tvrtko Ursulin (3):
>>    drm/sched: Add internal job peek/pop API
>>    drm/amdgpu: Pop jobs from the queue more robustly
>>    drm/sched: Remove a hole from struct drm_sched_job
>>
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_job.c    | 22 +++++++++--
>>   drivers/gpu/drm/scheduler/sched_entity.c   | 11 +++---
>>   drivers/gpu/drm/scheduler/sched_internal.h | 43 ++++++++++++++++++++++
>>   drivers/gpu/drm/scheduler/sched_main.c     |  7 ++--
>>   include/drm/gpu_scheduler.h                | 38 ++++++++++---------
>>   5 files changed, 90 insertions(+), 31 deletions(-)
>>   create mode 100644 drivers/gpu/drm/scheduler/sched_internal.h
>>
> 


More information about the amd-gfx mailing list