[PATCH] amdgpu/pm/legacy: fix suspend/resume issues
chr[]
chris at rudorff.com
Mon Feb 17 17:16:37 UTC 2025
On 17.02.25 16:26, Alex Deucher wrote:
> From: "chr[]" <chris at rudorff.com>
>
> resume and irq handler happily races in set_power_state()
>
> * amdgpu_legacy_dpm_compute_clocks() needs lock
> * protect irq work handler
> * fix dpm_enabled usage
>
> v2: fix clang build, integrate Lijo's comments (Alex)
>
> Closes: https://gitlab.freedesktop.org/drm/amd/-/issues/2524
> Fixes: 3712e7a49459 ("drm/amd/pm: unified lock protections in amdgpu_dpm.c")
> Tested-by: Maciej S. Szmigiero <mail at maciej.szmigiero.name> # on Oland PRO
> Signed-off-by: chr[] <chris at rudorff.com>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
> drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 25 +++++++++++++-----
> .../gpu/drm/amd/pm/legacy-dpm/legacy_dpm.c | 8 ++++--
> drivers/gpu/drm/amd/pm/legacy-dpm/si_dpm.c | 26 ++++++++++++++-----
> 3 files changed, 45 insertions(+), 14 deletions(-)
>
Hi @all,
thanks for the review and thanks for the rework.
I'm going to test onto v6.8.78 right now.
Maybe it's worth to mention this is a good candidate for backports?!
chr[]
More information about the amd-gfx
mailing list