[PATCH] drm/amdgpu: Remove redundant check of adev

Wang, Yang(Kevin) KevinYang.Wang at amd.com
Wed Feb 19 05:03:26 UTC 2025


[AMD Official Use Only - AMD Internal Distribution Only]

Reviewed-by: Yang Wang <kevinyang.wang at amd.com>

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Xiang Liu
Sent: Wednesday, February 19, 2025 12:37
To: amd-gfx at lists.freedesktop.org
Cc: kees at ijzerbout.nl; Zhang, Hawking <Hawking.Zhang at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>; Liu, Xiang(Dean) <Xiang.Liu at amd.com>
Subject: [PATCH] drm/amdgpu: Remove redundant check of adev

There is no need to check adev for sure.

Signed-off-by: Xiang Liu <xiang.liu at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
index c0da9096a7fa..d11593cd1922 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_aca.c
@@ -392,7 +392,7 @@ static void aca_banks_generate_cper(struct amdgpu_device *adev,
        struct aca_bank_node *node;
        struct aca_bank *bank;

-       if (!adev || !banks || !count) {
+       if (!banks || !count) {
                dev_warn(adev->dev, "fail to generate cper records\n");
                return;
        }
--
2.34.1



More information about the amd-gfx mailing list