[PATCH 2/2] drm/amdgpu/mes11: drop amdgpu_mes_suspend()/amdgpu_mes_resume() calls

[Liu, Shaoyun]

[AMD Official Use Only - AMD Internal Distribution Only]

This series looks good to me .

Reviewed-by :Shaoyun.liu <Shaoyun.liu@#amd.com>

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Tuesday, February 25, 2025 10:10 AM
To: Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/amdgpu/mes11: drop amdgpu_mes_suspend()/amdgpu_mes_resume() calls

Ping on this series?

On Fri, Feb 21, 2025 at 9:59 AM Alex Deucher <alexander.deucher at amd.com> wrote:
>
> They are noops on GFX11 for most firmware versions. KFD already
> handles its own queues and they should already be unmapped at this
> point so even if this runs, it's not doing anything.
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mes_v11_0.c | 14 +-------------
>  1 file changed, 1 insertion(+), 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> index e8aa28184bdd0..a569d09a1a748 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_v11_0.c
> @@ -1685,24 +1685,12 @@ static int mes_v11_0_hw_fini(struct
> amdgpu_ip_block *ip_block)
>
>  static int mes_v11_0_suspend(struct amdgpu_ip_block *ip_block)  {
> -       int r;
> -
> -       r = amdgpu_mes_suspend(ip_block->adev);
> -       if (r)
> -               return r;
> -
>         return mes_v11_0_hw_fini(ip_block);  }
>
>  static int mes_v11_0_resume(struct amdgpu_ip_block *ip_block)  {
> -       int r;
> -
> -       r = mes_v11_0_hw_init(ip_block);
> -       if (r)
> -               return r;
> -
> -       return amdgpu_mes_resume(ip_block->adev);
> +       return mes_v11_0_hw_init(ip_block);
>  }
>
>  static int mes_v11_0_early_init(struct amdgpu_ip_block *ip_block)
> --
> 2.48.1
>