[PATCH] drm/amdgpu: Mark debug KFD module params as unsafe

[Alex Deucher]

On Wed, Jan 8, 2025 at 10:18 AM Kent Russell <kent.russell at amd.com> wrote:
>
> Mark options only meant to be used for debugging as unsafe so that the
> kernel is tainted when they are used.
>
> Signed-off-by: Kent Russell <kent.russell at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index acb9dc3705ac..1371b56beba2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -751,7 +751,7 @@ module_param_named(use_xgmi_p2p, amdgpu_use_xgmi_p2p, int, 0444);
>   * assigns queues to HQDs.
>   */
>  int sched_policy = KFD_SCHED_POLICY_HWS;
> -module_param(sched_policy, int, 0444);
> +module_param_unsafe(sched_policy, int, 0444);
>  MODULE_PARM_DESC(sched_policy,
>         "Scheduling policy (0 = HWS (Default), 1 = HWS without over-subscription, 2 = Non-HWS (Used for debugging only)");
>
> @@ -801,7 +801,7 @@ MODULE_PARM_DESC(send_sigterm,
>   * Setting 1 enables halt on hang.
>   */
>  int halt_if_hws_hang;
> -module_param(halt_if_hws_hang, int, 0644);
> +module_param_unsafe(halt_if_hws_hang, int, 0644);
>  MODULE_PARM_DESC(halt_if_hws_hang, "Halt if HWS hang is detected (0 = off (default), 1 = on)");
>
>  /**
> @@ -810,7 +810,7 @@ MODULE_PARM_DESC(halt_if_hws_hang, "Halt if HWS hang is detected (0 = off (defau
>   * check says. Default value: false (rely on MEC2 firmware version check).
>   */
>  bool hws_gws_support;
> -module_param(hws_gws_support, bool, 0444);
> +module_param_unsafe(hws_gws_support, bool, 0444);
>  MODULE_PARM_DESC(hws_gws_support, "Assume MEC2 FW supports GWS barriers (false = rely on FW version check (Default), true = force supported)");
>
>  /**
> @@ -843,7 +843,7 @@ MODULE_PARM_DESC(no_system_mem_limit, "disable system memory limit (false = defa
>   */
>  int amdgpu_no_queue_eviction_on_vm_fault;
>  MODULE_PARM_DESC(no_queue_eviction_on_vm_fault, "No queue eviction on VM fault (0 = queue eviction, 1 = no queue eviction)");
> -module_param_named(no_queue_eviction_on_vm_fault, amdgpu_no_queue_eviction_on_vm_fault, int, 0444);
> +module_param_named_unsafe(no_queue_eviction_on_vm_fault, amdgpu_no_queue_eviction_on_vm_fault, int, 0444);
>  #endif
>
>  /**
> @@ -851,7 +851,7 @@ module_param_named(no_queue_eviction_on_vm_fault, amdgpu_no_queue_eviction_on_vm
>   */
>  int amdgpu_mtype_local;
>  MODULE_PARM_DESC(mtype_local, "MTYPE for local memory (0 = MTYPE_RW (default), 1 = MTYPE_NC, 2 = MTYPE_CC)");
> -module_param_named(mtype_local, amdgpu_mtype_local, int, 0444);
> +module_param_named_unsafe(mtype_local, amdgpu_mtype_local, int, 0444);
>
>  /**
>   * DOC: pcie_p2p (bool)
> --
> 2.43.0
>