[PATCH 6/9] drm/amdgpu: Enable devcoredump for JPEG4_0_5
Sathishkumar S
sathishkumar.sundararaju at amd.com
Tue Jan 28 09:09:47 UTC 2025
Add register list and enable devcoredump for JPEG4_0_5
Signed-off-by: Sathishkumar S <sathishkumar.sundararaju at amd.com>
---
drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c | 41 +++++++++++++++++++++++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
index 6b3656984957..8fbbfe66b139 100644
--- a/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
+++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v4_0_5.c
@@ -46,11 +46,28 @@
#define regJPEG_CGC_GATE_INTERNAL_OFFSET 0x4160
#define regUVD_NO_OP_INTERNAL_OFFSET 0x0029
+static const struct amdgpu_hwip_reg_entry jpeg_reg_list_4_0_5[] = {
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JPEG_POWER_STATUS),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JPEG_INT_STAT),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JRBC_RB_RPTR),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JRBC_RB_WPTR),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JRBC_RB_CNTL),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JRBC_RB_SIZE),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JRBC_STATUS),
+ SOC15_REG_ENTRY_STR(VCN, 0, regJPEG_DEC_ADDR_MODE),
+ SOC15_REG_ENTRY_STR(VCN, 0, regJPEG_DEC_GFX10_ADDR_CONFIG),
+ SOC15_REG_ENTRY_STR(VCN, 0, regJPEG_DEC_Y_GFX10_TILING_SURFACE),
+ SOC15_REG_ENTRY_STR(VCN, 0, regJPEG_DEC_UV_GFX10_TILING_SURFACE),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JPEG_PITCH),
+ SOC15_REG_ENTRY_STR(VCN, 0, regUVD_JPEG_UV_PITCH),
+};
+
static void jpeg_v4_0_5_set_dec_ring_funcs(struct amdgpu_device *adev);
static void jpeg_v4_0_5_set_irq_funcs(struct amdgpu_device *adev);
static int jpeg_v4_0_5_set_powergating_state(struct amdgpu_ip_block *ip_block,
enum amd_powergating_state state);
-
+static void jpeg_v4_0_5_dump_ip_state(struct amdgpu_ip_block *ip_block);
+static void jpeg_v4_0_5_print_ip_state(struct amdgpu_ip_block *ip_block, struct drm_printer *p);
static void jpeg_v4_0_5_dec_ring_set_wptr(struct amdgpu_ring *ring);
static int amdgpu_ih_clientid_jpeg[] = {
@@ -58,6 +75,8 @@ static int amdgpu_ih_clientid_jpeg[] = {
SOC15_IH_CLIENTID_VCN1
};
+
+
/**
* jpeg_v4_0_5_early_init - set function pointers
*
@@ -153,6 +172,11 @@ static int jpeg_v4_0_5_sw_init(struct amdgpu_ip_block *ip_block)
adev->jpeg.inst[i].external.jpeg_pitch[0] = SOC15_REG_OFFSET(JPEG, i, regUVD_JPEG_PITCH);
}
+ adev->jpeg.ip_dump = kcalloc(adev->jpeg.num_jpeg_inst * ARRAY_SIZE(jpeg_reg_list_4_0_5),
+ sizeof(uint32_t), GFP_KERNEL);
+ if (!adev->jpeg.ip_dump)
+ DRM_ERROR("Failed to allocate memory for JPEG IP Dump\n");
+
/* TODO: Add queue reset mask when FW fully supports it */
adev->jpeg.supported_reset =
amdgpu_get_soft_full_reset_mask(&adev->jpeg.inst[0].ring_dec[0]);
@@ -182,6 +206,8 @@ static int jpeg_v4_0_5_sw_fini(struct amdgpu_ip_block *ip_block)
amdgpu_jpeg_sysfs_reset_mask_fini(adev);
r = amdgpu_jpeg_sw_fini(adev);
+ kfree(adev->jpeg.ip_dump);
+
return r;
}
@@ -746,6 +772,17 @@ static int jpeg_v4_0_5_process_interrupt(struct amdgpu_device *adev,
return 0;
}
+static void jpeg_v4_0_5_dump_ip_state(struct amdgpu_ip_block *ip_block)
+{
+ amdgpu_jpeg_dump_ip_state(ip_block, jpeg_reg_list_4_0_5, ARRAY_SIZE(jpeg_reg_list_4_0_5));
+}
+
+static void jpeg_v4_0_5_print_ip_state(struct amdgpu_ip_block *ip_block, struct drm_printer *p)
+{
+ amdgpu_jpeg_print_ip_state(ip_block, p, jpeg_reg_list_4_0_5,
+ ARRAY_SIZE(jpeg_reg_list_4_0_5));
+}
+
static const struct amd_ip_funcs jpeg_v4_0_5_ip_funcs = {
.name = "jpeg_v4_0_5",
.early_init = jpeg_v4_0_5_early_init,
@@ -759,6 +796,8 @@ static const struct amd_ip_funcs jpeg_v4_0_5_ip_funcs = {
.wait_for_idle = jpeg_v4_0_5_wait_for_idle,
.set_clockgating_state = jpeg_v4_0_5_set_clockgating_state,
.set_powergating_state = jpeg_v4_0_5_set_powergating_state,
+ .dump_ip_state = jpeg_v4_0_5_dump_ip_state,
+ .print_ip_state = jpeg_v4_0_5_print_ip_state,
};
static const struct amdgpu_ring_funcs jpeg_v4_0_5_dec_ring_vm_funcs = {
--
2.25.1
More information about the amd-gfx
mailing list