[PATCH] drm/amdkfd: Ensure consistent barrier state saved in gfx12 trap handler

Jay Cornwall jay.cornwall at amd.com
Tue Jan 28 19:52:40 UTC 2025


On 1/28/2025 13:16, Lancelot SIX wrote:
> It is possible for some waves in a workgroup to finish their save
> sequence before the group leader has had time to capture the workgroup
> barrier state.  When this happens, having those waves exit do impact the
> barrier state.  As a consequence, the state captured by the group leader
> is invalid, and is eventually incorrectly restored.
> 
> This patch proposes to have all waves in a workgroup wait for each other
> at the end of their save sequence (just before calling s_endpgm_saved).
> 
> Signed-off-by: Lancelot SIX <lancelot.six at amd.com>

Reviewed-by: Jay Cornwall <jay.cornwall at amd.com>



More information about the amd-gfx mailing list