[PATCH 10/36] drm/amdgpu/vcn5: add additional ring reset error checking

Mario Limonciello mario.limonciello at amd.com
Mon Jul 7 19:05:14 UTC 2025


On 7/7/2025 3:03 PM, Alex Deucher wrote:
> Start and stop can fail, so add checks.
> 
> Fixes: b54695dae995 ("drm/amd: Add per-ring reset for vcn v5.0.0 use")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> Cc: Mario Limonciello <mario.limonciello at amd.com>
Reviewed-by: Mario Limonciello <mari.limonciello at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> index 47c0bcc9e7d80..3d3b4254bd729 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_0.c
> @@ -1204,8 +1204,12 @@ static int vcn_v5_0_0_ring_reset(struct amdgpu_ring *ring,
>   		return -EOPNOTSUPP;
>   
>   	drm_sched_wqueue_stop(&ring->sched);
> -	vcn_v5_0_0_stop(vinst);
> -	vcn_v5_0_0_start(vinst);
> +	r = vcn_v5_0_0_stop(vinst);
> +	if (r)
> +		return r;
> +	r = vcn_v5_0_0_start(vinst);
> +	if (r)
> +		return r;
>   
>   	r = amdgpu_ring_test_helper(ring);
>   	if (r)



More information about the amd-gfx mailing list