[PATCH 2/3] tests/amdgpu: Rename set_abm_level to set_abm_level_sysfs

Mario Limonciello superm1 at kernel.org
Mon Jul 21 02:13:18 UTC 2025


From: Mario Limonciello <mario.limonciello at amd.com>

The compositor can set the ABM level directly, so rename the function
to clarify which method is being used.

Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
---
 tests/amdgpu/amd_abm.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index f55b055f9..3c6a7307f 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -50,7 +50,7 @@ typedef struct data {
 	uint32_t *fb_mem;
 } data_t;
 
-static void set_abm_level(data_t *data, igt_output_t *output, int level);
+static void set_abm_level_sysfs(data_t *data, igt_output_t *output, int level);
 
 static void fbmem_draw_smpte_pattern(uint32_t *fbmem, int width, int height)
 {
@@ -173,7 +173,7 @@ static void test_fini(data_t *data)
 	for_each_valid_output_on_pipe(&data->display, pipe, output) {
 		if (output->config.connector->connector_type != DRM_MODE_CONNECTOR_eDP)
 			continue;
-		set_abm_level(data, output, 0);
+		set_abm_level_sysfs(data, output, 0);
 	}
 
 	igt_display_reset(display);
@@ -247,7 +247,7 @@ static int backlight_write_brightness(int value)
 	return 0;
 }
 
-static void set_abm_level(data_t *data, igt_output_t *output, int level)
+static void set_abm_level_sysfs(data_t *data, igt_output_t *output, int level)
 {
 	char buf[PATH_MAX];
 	int fd;
@@ -334,7 +334,7 @@ static void backlight_dpms_cycle(data_t *data)
 		ret = backlight_read_max_brightness(&max_brightness);
 		igt_assert_eq(ret, 0);
 
-		set_abm_level(data, output, 0);
+		set_abm_level_sysfs(data, output, 0);
 		backlight_write_brightness(max_brightness / 2);
 		usleep(100000);
 		pwm_1 = read_target_backlight_pwm(data->drm_fd, output->name);
@@ -365,7 +365,7 @@ static void backlight_monotonic_basic(data_t *data)
 
 		brightness_step = max_brightness / 10;
 
-		set_abm_level(data, output, 0);
+		set_abm_level_sysfs(data, output, 0);
 		backlight_write_brightness(max_brightness);
 		usleep(100000);
 		prev_pwm = read_target_backlight_pwm(data->drm_fd, output->name);
@@ -399,7 +399,7 @@ static void backlight_monotonic_abm(data_t *data)
 
 		brightness_step = max_brightness / 10;
 		for (i = 1; i < 5; i++) {
-			set_abm_level(data, output, i);
+			set_abm_level_sysfs(data, output, i);
 			backlight_write_brightness(max_brightness);
 			usleep(100000);
 			prev_pwm = read_target_backlight_pwm(data->drm_fd, output->name);
@@ -431,14 +431,14 @@ static void abm_enabled(data_t *data)
 		ret = backlight_read_max_brightness(&max_brightness);
 		igt_assert_eq(ret, 0);
 
-		set_abm_level(data, output, 0);
+		set_abm_level_sysfs(data, output, 0);
 		backlight_write_brightness(max_brightness-max_brightness/10);
 		usleep(100000);
 		prev_pwm = read_target_backlight_pwm(data->drm_fd, output->name);
 		pwm_without_abm = prev_pwm;
 
 		for (i = 1; i < 5; i++) {
-			set_abm_level(data, output, i);
+			set_abm_level_sysfs(data, output, i);
 			usleep(100000);
 			page_flip(data, output, 10);
 			pwm = read_target_backlight_pwm(data->drm_fd, output->name);
@@ -466,7 +466,7 @@ static void abm_gradual(data_t *data)
 
 		igt_assert_eq(ret, 0);
 
-		set_abm_level(data, output, 0);
+		set_abm_level_sysfs(data, output, 0);
 		backlight_write_brightness(max_brightness-max_brightness/10);
 
 		sleep(convergence_delay);
@@ -474,7 +474,7 @@ static void abm_gradual(data_t *data)
 		curr = read_current_backlight_pwm(data->drm_fd, output->name);
 
 		igt_assert_eq(prev_pwm, curr);
-		set_abm_level(data, output, 4);
+		set_abm_level_sysfs(data, output, 4);
 		for (i = 0; i < 10; i++) {
 			usleep(100000);
 			page_flip(data, output, 10);
-- 
2.50.1



More information about the amd-gfx mailing list