[PATCH] drm/amd/display: Fix misuse of /** to /* in 'dce_i2c_hw.c'
Alex Hung
alex.hung at amd.com
Wed Jul 23 22:28:29 UTC 2025
Reviewed-by: Alex Hung <alex.hung at amd.com>
On 7/21/25 07:22, Srinivasan Shanmugam wrote:
> Fix the comment style before cntl_stuck_hw_workaround() by replacing
> '/**' with '/*' since it is not a kdoc comment.
>
> Fixes the below with gcc W=1:
> display/dc/dce/dce_i2c_hw.c:380: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * If we boot without an HDMI display, the I2C engine does not get
> initialized
>
> Fixes: c9130176a41e ("drm/amd/display: Workaround for stuck I2C arbitrage")
> Cc: Alvin Lee <alvin.lee2 at amd.com>
> Cc: Dominik Kaszewski <dominik.kaszewski at amd.com>
> Cc: Ivan Lipski <ivan.lipski at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Tom Chung <chiahsuan.chung at amd.com>
> Cc: Roman Li <roman.li at amd.com>
> Cc: Alex Hung <alex.hung at amd.com>
> Cc: Aurabindo Pillai <aurabindo.pillai at amd.com>
> Signed-off-by: Srinivasan Shanmugam <srinivasan.shanmugam at amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c
> index 4e06468a6284..0421b267a0b5 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c
> @@ -377,10 +377,16 @@ static bool setup_engine(
> }
>
> /**
> + * cntl_stuck_hw_workaround - Workaround for I2C engine stuck state
> + * @dce_i2c_hw: Pointer to dce_i2c_hw structure
> + *
> * If we boot without an HDMI display, the I2C engine does not get initialized
> * correctly. One of its symptoms is that SW_USE_I2C does not get cleared after
> - * acquire, so that after setting SW_DONE_USING_I2C on release, the engine gets
> + * acquire. After setting SW_DONE_USING_I2C on release, the engine gets
> * immediately reacquired by SW, preventing DMUB from using it.
> + *
> + * This function checks the I2C arbitration status and applies a release
> + * workaround if necessary.
> */
> static void cntl_stuck_hw_workaround(struct dce_i2c_hw *dce_i2c_hw)
> {
More information about the amd-gfx
mailing list