[PATCH 2/3] drm/amd/display: Don't overwrite dce60_clk_mgr

Alex Deucher alexdeucher at gmail.com
Mon Jul 28 18:18:06 UTC 2025


On Tue, Jul 22, 2025 at 11:58 AM Timur Kristóf <timur.kristof at gmail.com> wrote:
>
> dc_clk_mgr_create accidentally overwrites the dce60_clk_mgr
> with the dce_clk_mgr, causing incorrect behaviour on DCE6.
> Fix it by removing the extra dce_clk_mgr_construct.
>
> Fixes: 62eab49faae7 ("drm/amd/display: hide VGH asic specific structs")
> Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
> index 33b9d36619ff..4071851f9e86 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/clk_mgr.c
> @@ -158,7 +158,6 @@ struct clk_mgr *dc_clk_mgr_create(struct dc_context *ctx, struct pp_smu_funcs *p
>                         return NULL;
>                 }
>                 dce60_clk_mgr_construct(ctx, clk_mgr);
> -               dce_clk_mgr_construct(ctx, clk_mgr);
>                 return &clk_mgr->base;
>         }
>  #endif
> --
> 2.50.1
>


More information about the amd-gfx mailing list