[PATCH Review 2/2] drm/amdgpu: Add new error code for VCN/JPEG new chain

[Wang, Yang(Kevin)]

[AMD Official Use Only - AMD Internal Distribution Only]

        16, 17, 18, 19, 20, 21, 22, 23, /* JPEG[0-7][S|D] */

it is better to correct/add the code comments before submit patch, after that the series patch is

Reviewed-by: Yang Wang <kevinyang.wang at amd.com>

Best Regards,
Kevin

-----Original Message-----
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Stanley.Yang
Sent: Tuesday, July 29, 2025 11:32 AM
To: amd-gfx at lists.freedesktop.org
Cc: Yang, Stanley <Stanley.Yang at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: [PATCH Review 2/2] drm/amdgpu: Add new error code for VCN/JPEG new chain

Add VIDS and JPEG8/9 S|D chain error code for VCN/JPEG v5.0.1.

Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c | 3 ++-  drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c  | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c
index 51b9148626fc..961ab557fed7 100644
--- a/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/jpeg_v5_0_1.c
@@ -1028,7 +1028,8 @@ static int jpeg_v5_0_1_aca_bank_parser(struct aca_handle *handle, struct aca_ban
 /* reference to smu driver if header file */  static int jpeg_v5_0_1_err_codes[] = {
        16, 17, 18, 19, 20, 21, 22, 23, /* JPEG[0-7][S|D] */
-       24, 25, 26, 27, 28, 29, 30, 31
+       24, 25, 26, 27, 28, 29, 30, 31,
+       48, 49, 50, 51,
 };

 static bool jpeg_v5_0_1_aca_bank_is_valid(struct aca_handle *handle, struct aca_bank *bank, diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
index 0333a2833b2e..120414fb024d 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v5_0_1.c
@@ -1565,7 +1565,7 @@ static int vcn_v5_0_1_aca_bank_parser(struct aca_handle *handle, struct aca_bank

 /* reference to smu driver if header file */  static int vcn_v5_0_1_err_codes[] = {
-       14, 15, /* VCN */
+       14, 15, 47, /* VCN [D|V|S] */
 };

 static bool vcn_v5_0_1_aca_bank_is_valid(struct aca_handle *handle, struct aca_bank *bank,
--
2.25.1