[RFC PATCH 2/2] drm/amdgpu/uvd: Ensure vcpu bos are within the uvd segment
John Olender
john.olender at gmail.com
Thu Jun 5 09:21:47 UTC 2025
On 5/2/25 4:36 AM, Christian König wrote:
>> I think we can just make this VRAM only. Or something like:
>> adev->uvd.address_64_bit ? AMDGPU_GEM_DOMAIN_GTT : AMDGPU_GEM_DOMAIN_VRAM
> Yeah completely agree. It's a good catch, but the solution is incorrect.
>
> On the older UVD MC interface the FW needs to be in VRAM or the validation fails. If it's inside the window for the message and fence is actually irrelevant.
>
> So something like AMDGPU_GEM_DOMAIN_VRAM | (adev->uvd.address_64_bit ? AMDGPU_GEM_DOMAIN_GTT : 0) would be correct I think.
>
>> If that fixes it, this should be tagged with:
>> Fixes: 58ab2c08d708 ("drm/amdgpu: use VRAM|GTT for a bunch of kernel
>> allocations")
> And CC stable I think.
>
> Regards,
> Christian.
>
>> Alex
The simplified patch needs this change to the vcpu bo domain. Would you
prefer this change as a separate patch?
Thanks,
John
More information about the amd-gfx
mailing list