[PATCH v2] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()
kernel test robot
lkp at intel.com
Mon Jun 9 19:21:00 UTC 2025
Hi Markus,
kernel test robot noticed the following build errors:
[auto build test ERROR on next-20250606]
[also build test ERROR on v6.16-rc1]
[cannot apply to drm-exynos/exynos-drm-next linus/master drm-intel/for-linux-next drm-intel/for-linux-next-fixes drm/drm-next drm-misc/drm-misc-next v6.16-rc1 v6.15 v6.15-rc7]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Markus-Elfring/drm-amd-display-Fix-exception-handling-in-dm_validate_stream_and_context/20250609-151039
base: next-20250606
patch link: https://lore.kernel.org/r/da489521-7786-4716-8fb8-d79b3c08d93c%40web.de
patch subject: [PATCH v2] drm/amd/display: Fix exception handling in dm_validate_stream_and_context()
config: x86_64-buildonly-randconfig-005-20250609 (https://download.01.org/0day-ci/archive/20250610/202506100312.Ms4XgAzW-lkp@intel.com/config)
compiler: clang version 20.1.2 (https://github.com/llvm/llvm-project 58df0ef89dd64126512e4ee27b4ac3fd8ddf6247)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250610/202506100312.Ms4XgAzW-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp at intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202506100312.Ms4XgAzW-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7525:2: error: call to undeclared function 'dc_release_state'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
7525 | dc_release_state(dc_state);
| ^
1 error generated.
vim +/dc_release_state +7525 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c
7471
7472 static enum dc_status dm_validate_stream_and_context(struct dc *dc,
7473 struct dc_stream_state *stream)
7474 {
7475 enum dc_status dc_result = DC_ERROR_UNEXPECTED;
7476 struct dc_plane_state *dc_plane_state;
7477 struct dc_state *dc_state;
7478
7479 if (!stream)
7480 return dc_result;
7481
7482 dc_plane_state = dc_create_plane_state(dc);
7483 if (!dc_plane_state)
7484 return dc_result;
7485
7486 dc_state = dc_state_create(dc, NULL);
7487 if (!dc_state)
7488 goto release_plane_state;
7489
7490 /* populate stream to plane */
7491 dc_plane_state->src_rect.height = stream->src.height;
7492 dc_plane_state->src_rect.width = stream->src.width;
7493 dc_plane_state->dst_rect.height = stream->src.height;
7494 dc_plane_state->dst_rect.width = stream->src.width;
7495 dc_plane_state->clip_rect.height = stream->src.height;
7496 dc_plane_state->clip_rect.width = stream->src.width;
7497 dc_plane_state->plane_size.surface_pitch = ((stream->src.width + 255) / 256) * 256;
7498 dc_plane_state->plane_size.surface_size.height = stream->src.height;
7499 dc_plane_state->plane_size.surface_size.width = stream->src.width;
7500 dc_plane_state->plane_size.chroma_size.height = stream->src.height;
7501 dc_plane_state->plane_size.chroma_size.width = stream->src.width;
7502 dc_plane_state->format = SURFACE_PIXEL_FORMAT_GRPH_ARGB8888;
7503 dc_plane_state->tiling_info.gfx9.swizzle = DC_SW_UNKNOWN;
7504 dc_plane_state->rotation = ROTATION_ANGLE_0;
7505 dc_plane_state->is_tiling_rotated = false;
7506 dc_plane_state->tiling_info.gfx8.array_mode = DC_ARRAY_LINEAR_GENERAL;
7507
7508 dc_result = dc_validate_stream(dc, stream);
7509 if (dc_result == DC_OK)
7510 dc_result = dc_validate_plane(dc, dc_plane_state);
7511
7512 if (dc_result == DC_OK)
7513 dc_result = dc_state_add_stream(dc, dc_state, stream);
7514
7515 if (dc_result == DC_OK && !dc_state_add_plane(
7516 dc,
7517 stream,
7518 dc_plane_state,
7519 dc_state))
7520 dc_result = DC_FAIL_ATTACH_SURFACES;
7521
7522 if (dc_result == DC_OK)
7523 dc_result = dc_validate_global_state(dc, dc_state, DC_VALIDATE_MODE_ONLY);
7524
> 7525 dc_release_state(dc_state);
7526 release_plane_state:
7527 dc_plane_state_release(dc_plane_state);
7528 return dc_result;
7529 }
7530
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
More information about the amd-gfx
mailing list