[PATCH v2 11/11] drm/amdgpu: clean up the amdgpu_userq_active()

Alex Deucher alexdeucher at gmail.com
Tue Jun 17 14:52:49 UTC 2025


On Tue, Jun 17, 2025 at 4:27 AM Prike Liang <Prike.Liang at amd.com> wrote:
>
> This is no invocation for amdgpu_userq_active().
>
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 16 ----------------
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h |  2 --
>  2 files changed, 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index be3220a973ae..f3028f344bcd 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -258,22 +258,6 @@ amdgpu_userq_cleanup(struct amdgpu_userq_mgr *uq_mgr,
>         kfree(queue);
>  }
>
> -int
> -amdgpu_userq_active(struct amdgpu_userq_mgr *uq_mgr)
> -{
> -       struct amdgpu_usermode_queue *queue;
> -       int queue_id;
> -       int ret = 0;
> -
> -       mutex_lock(&uq_mgr->userq_mutex);
> -       /* Resume all the queues for this process */
> -       idr_for_each_entry(&uq_mgr->userq_idr, queue, queue_id)
> -               ret += queue->state == AMDGPU_USERQ_STATE_MAPPED;
> -
> -       mutex_unlock(&uq_mgr->userq_mutex);
> -       return ret;
> -}
> -
>  static struct amdgpu_usermode_queue *
>  amdgpu_userq_find(struct amdgpu_userq_mgr *uq_mgr, int qid)
>  {
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
> index 7e532ca0ba05..929d04c70971 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.h
> @@ -118,8 +118,6 @@ void amdgpu_userq_destroy_object(struct amdgpu_userq_mgr *uq_mgr,
>  void amdgpu_userq_evict(struct amdgpu_userq_mgr *uq_mgr,
>                         struct amdgpu_eviction_fence *ev_fence);
>
> -int amdgpu_userq_active(struct amdgpu_userq_mgr *uq_mgr);
> -
>  void amdgpu_userq_ensure_ev_fence(struct amdgpu_userq_mgr *userq_mgr,
>                                   struct amdgpu_eviction_fence_mgr *evf_mgr);
>
> --
> 2.34.1
>


More information about the amd-gfx mailing list