[PATCH v2 02/11] drm/amdgpu: validate unmap status for destroying userq

[Alex Deucher]

On Tue, Jun 17, 2025 at 4:56 AM Prike Liang <Prike.Liang at amd.com> wrote:
>
> Before destroying the userq buffer object, it requires validating
> the userq unmap status and ensuring the userq is unmapped from
> hardware.
>
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index f67969312c39..e3cebe532c7b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -319,6 +319,11 @@ amdgpu_userq_destroy(struct drm_file *filp, int queue_id)
>         }
>         amdgpu_bo_unref(&queue->db_obj.obj);
>         r = amdgpu_userq_unmap_helper(uq_mgr, queue);
> +       /*TODO: It requires a reset for unmap error*/
> +       if (r != AMDGPU_USERQ_STATE_UNMAPPED) {
> +               drm_warn(adev_to_drm(uq_mgr->adev), "trying to destroy a HW mapping userq\n");
> +               r = -ETIMEDOUT;
> +       }
>         amdgpu_userq_cleanup(uq_mgr, queue, queue_id);
>         mutex_unlock(&uq_mgr->userq_mutex);
>
> --
> 2.34.1
>