[PATCH 0/4] Add ISP Generic PM Domain (genpd) support

Pratap Nirujogi pratap.nirujogi at amd.com
Wed Jun 18 22:17:21 UTC 2025


This patch series adds support to control ISP power and clocks using the
Generic PM Domain (genpd). Its required to control the ISP HW power from
external I2C driver to successfully probe the sensor device. Instead of
using an exported symbols from ISP driver, enabling Generic PM Domain (genpd)
support in amdgpu_isp device allows its child devices (amd_isp_capture,
amd_isp_i2c_designware) to set power and clocks directly using PM method.

We need to add support in amdgpu_smu as well for amdgpu_isp device to set
power / clocks when invoked from genpd. Though the below SMU messages are
defined, the actual support to configure ISP is missing in SMU interface.

PPSMC_MSG_PowerDownIspByTile
PPSMC_MSG_PowerUpIspByTile
PPSMC_MSG_SetHardMinIspiclkByFreq
PPSMC_MSG_SetHardMinIspxclkByFreq

Added support in SMU to control ISP power / clocks by updating the existing
amdgpu_dpm_set_powergating_by_smu() and amdgpu_dpm_set_soft_freq_range(); and
the underlying SOC specific SMU implementation for isp v4.1.

Pratap Nirujogi (4):
  drm/amd/pm: Add support to set ISP Power
  drm/amd/pm: Add support to set min ISP clocks
  drm/amd/amdgpu: Add ISP Generic PM Domain (genpd) support
  drm/amd/amdgpu: Refine isp_v4_1_1 logging

 drivers/gpu/drm/amd/amdgpu/amdgpu_isp.h       |   3 +
 drivers/gpu/drm/amd/amdgpu/isp_v4_1_1.c       | 173 ++++++++++++++++--
 .../gpu/drm/amd/include/kgd_pp_interface.h    |   2 +
 drivers/gpu/drm/amd/pm/amdgpu_dpm.c           |  15 +-
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c     |  41 ++++-
 drivers/gpu/drm/amd/pm/swsmu/inc/amdgpu_smu.h |   9 +-
 .../inc/pmfw_if/smu14_driver_if_v14_0_0.h     |   1 +
 drivers/gpu/drm/amd/pm/swsmu/inc/smu_types.h  |   2 +
 .../drm/amd/pm/swsmu/smu14/smu_v14_0_0_ppt.c  |  60 ++++--
 9 files changed, 264 insertions(+), 42 deletions(-)

-- 
2.43.0



More information about the amd-gfx mailing list