[PATCH v4 03/11] drm/amdgpu: unify the userq doorbell object destroy

[Christian König]

On 24.06.25 10:45, Prike Liang wrote:
> Unify and refine the userq doorbell object destroy.
> 
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c  | 1 -
>  drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 4 ++++
>  2 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> index c7c9f9e597f1..acaea4416ed2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq.c
> @@ -317,7 +317,6 @@ amdgpu_userq_destroy(struct drm_file *filp, int queue_id)
>  		amdgpu_bo_unpin(queue->db_obj.obj);
>  		amdgpu_bo_unreserve(queue->db_obj.obj);
>  	}
> -	amdgpu_bo_unref(&queue->db_obj.obj);
>  	r = amdgpu_userq_unmap_helper(uq_mgr, queue);
>  	/*TODO: It requires a reset for unmap error*/
>  	if (r != AMDGPU_USERQ_STATE_UNMAPPED) {
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> index 1457fb49a794..dbacdfcb6f7b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> @@ -336,6 +336,10 @@ mes_userq_mqd_destroy(struct amdgpu_userq_mgr *uq_mgr,
>  		      struct amdgpu_usermode_queue *queue)
>  {
>  	amdgpu_userq_destroy_object(uq_mgr, &queue->fw_obj);
> +	/*Validate the doorbell obj whether has unpinned by amdgpu_userq_destroy()*/
> +	if (queue->db_obj.obj->tbo.pin_count)
> +		amdgpu_bo_unpin(queue->db_obj.obj);
> +	amdgpu_userq_destroy_object(uq_mgr, &queue->db_obj);

Absolutely clear NAK! You are breaking tons of things here.

What the heck are you trying to do?

Regards,
Christian.


>  	kfree(queue->userq_prop);
>  	amdgpu_userq_destroy_object(uq_mgr, &queue->mqd);
>  }