[PATCH 2/2] drm/radeon/evergreen_cs: lower evergreen_surface_check_linear_aligned restriction

Alex Deucher alexdeucher at gmail.com
Fri Jun 27 14:46:15 UTC 2025


BTW, do you want to send a patch to bump the driver version so that
mesa can check for this and determine whether or not to enable this
functionality?  See KMS_DRIVER_MINOR in radeon_drv.c.

Alex

On Fri, Jun 20, 2025 at 5:41 PM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> Applied the series.
>
> Thanks!
>
> On Tue, Jun 10, 2025 at 3:12 PM Patrick Lerda <patrick9876 at free.fr> wrote:
> >
> > This change removes the restriction when palign=64 and nbx=32.
> > This makes two piglit tests working. This is discussed on the
> > thread linked below.
> >
> > Link: https://gitlab.freedesktop.org/mesa/mesa/-/issues/9056
> > Signed-off-by: Patrick Lerda <patrick9876 at free.fr>
> > ---
> >  drivers/gpu/drm/radeon/evergreen_cs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/evergreen_cs.c b/drivers/gpu/drm/radeon/evergreen_cs.c
> > index 7d00096fc915..266c57733136 100644
> > --- a/drivers/gpu/drm/radeon/evergreen_cs.c
> > +++ b/drivers/gpu/drm/radeon/evergreen_cs.c
> > @@ -211,7 +211,7 @@ static int evergreen_surface_check_linear_aligned(struct radeon_cs_parser *p,
> >         surf->base_align = track->group_size;
> >         surf->palign = palign;
> >         surf->halign = 1;
> > -       if (surf->nbx & (palign - 1)) {
> > +       if ((surf->nbx & (palign - 1)) && !(palign == 64 && surf->nbx == 32)) {
> >                 if (prefix) {
> >                         dev_warn(p->dev, "%s:%d %s pitch %d invalid must be aligned with %d\n",
> >                                  __func__, __LINE__, prefix, surf->nbx, palign);
> > --
> > 2.49.0
> >


More information about the amd-gfx mailing list