[PATCH] drm/amd/display: Use str_on_off() helper

[Deucher, Alexander]

[Public]

> -----Original Message-----
> From: long.yunjian at zte.com.cn <long.yunjian at zte.com.cn>
> Sent: Friday, June 20, 2025 11:28 PM
> To: Wentland, Harry <Harry.Wentland at amd.com>
> Cc: Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; siqueira at igalia.com; Deucher,
> Alexander <Alexander.Deucher at amd.com>; Koenig, Christian
> <Christian.Koenig at amd.com>; airlied at gmail.com; simona at ffwll.ch;
> fang.yumeng at zte.com.cn; amd-gfx at lists.freedesktop.org; dri-
> devel at lists.freedesktop.org; linux-kernel at vger.kernel.org; mou.yi at zte.com.cn;
> xu.lifeng1 at zte.com.cn; ouyang.maochun at zte.com.cn
> Subject: [PATCH] drm/amd/display: Use str_on_off() helper
>
> From: Yumeng Fang <fang.yumeng at zte.com.cn>
>
> Remove hard-coded strings by using the str_on_off() helper.

I personally find that these helpers hurt readability.

Alex

>
> Signed-off-by: Yumeng Fang <fang.yumeng at zte.com.cn>
> ---
>  drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> b/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> index af21c0a27f86..509bdb1ca9bc 100644
> --- a/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> +++ b/drivers/gpu/drm/amd/display/dc/pg/dcn35/dcn35_pg_cntl.c
> @@ -24,6 +24,7 @@
>   *
>   */
>
> +#include <linux/string_choices.h>
>  #include "reg_helper.h"
>  #include "core_types.h"
>  #include "dcn35_pg_cntl.h"
> @@ -236,7 +237,7 @@ void pg_cntl35_hubp_dpp_pg_control(struct pg_cntl
> *pg_cntl, unsigned int hubp_dp
>       }
>
>       DC_LOG_DEBUG("HUBP DPP instance %d, power %s", hubp_dpp_inst,
> -             power_on ? "ON" : "OFF");
> +             str_on_off(power_on));
>
>       if (hubp_dpp_inst < MAX_PIPES) {
>               pg_cntl->pg_pipe_res_enable[PG_HUBP][hubp_dpp_inst] =
> power_on;
> --
> 2.25.1