[PATCH 5/5] drm/amdgpu/userq: remove BROKEN from config

[Liang, Prike]

[Public]

> From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Tuesday, March 4, 2025 12:15 AM
> To: Liang, Prike <Prike.Liang at amd.com>
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; amd-
> gfx at lists.freedesktop.org
> Subject: Re: [PATCH 5/5] drm/amdgpu/userq: remove BROKEN from config
>
> On Mon, Mar 3, 2025 at 7:09 AM Liang, Prike <Prike.Liang at amd.com> wrote:
> >
> > [Public]
> >
> > Question: Why use the CONFIG_DRM_AMDGPU_NAVI3X_USERQ to guard all
> the various GFX user mode queue enablement paths? It seems more generic and
> reasonable to use the config name CONFIG_DRM_AMDGPU_NAVI3X_USERQ.
> >
>
> I assume you mean something more generic like
> CONFIG_DRM_AMDGPU_USERQ?
>  At this point it would make more sense, but at the time it was added there was
> only gfx11 support.  We could change it, but at this point, I'd be more inclined to
> just remove it.
>
Yes, it's a typo, and I mean we may need to change the userq config label to CONFIG_DRM_AMDGPU_USERQ later.

Thanks,
Prike

> > Except for that question, the series patch is Reviewed-by: Prike Liang
> <Prike.Liang at amd.com> .
>
> Thanks.
>
> Alex
>
> >
> > Regards,
> >       Prike
> >
> > > -----Original Message-----
> > > From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of
> > > Alex Deucher
> > > Sent: Saturday, March 1, 2025 3:54 AM
> > > To: amd-gfx at lists.freedesktop.org
> > > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> > > Subject: [PATCH 5/5] drm/amdgpu/userq: remove BROKEN from config
> > >
> > > This can be enabled now.  We have the firmware checks in place.
> > >
> > > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > > ---
> > >  drivers/gpu/drm/amd/amdgpu/Kconfig | 1 -
> > >  1 file changed, 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > index a614320114796..23c014da0f324 100644
> > > --- a/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > +++ b/drivers/gpu/drm/amd/amdgpu/Kconfig
> > > @@ -98,7 +98,6 @@ config DRM_AMDGPU_WERROR  config
> > > DRM_AMDGPU_NAVI3X_USERQ
> > >       bool "Enable amdgpu usermode queues"
> > >       depends on DRM_AMDGPU
> > > -     depends on BROKEN
> > >       default n
> > >       help
> > >         Choose this option to enable GFX usermode queue support for
> > > GFX/SDMA/Compute
> > > --
> > > 2.48.1
> >