[PATCH] drm/amdgpu: Validate return value of pm_runtime_get_sync

[Alex Deucher]

On Tue, Mar 4, 2025 at 1:14 PM Mario Limonciello
<mario.limonciello at amd.com> wrote:
>
> On 3/4/2025 12:03, Khatri, Sunil wrote:
> > For new code can you please use drm_err() instead of DRM_ERROR()?
> > I see drm_err is not used anywhere in amdgpu driver but display is using it. I think it would be better if I take it in a different patch to change instead. Does that sounds ok ?
> >
>
> DRM_ERROR() doesn't give any information on a multi-GPU system which GPU
> had the problem.  drm_err() does.  So it's the preferred macro for errors.
>
> Up to Alex and Christian if they take this as is or spin it, but I think
> it's a very simple change.

Please use the dev_err() or drm_err() variants. We mostly use the dev
variants outside of the display code.

Alex

>
> > Regards
> > Sunil Khatri
> >
> >> +             pm_runtime_put_autosuspend(adev_to_drm(adev)->dev);
> >>                goto free_mqd;
> >> +     }
> >>
> >>        r = mqd_hw_default->init_mqd(adev, (void *)queue->mqd.cpu_ptr, userq_props);
> >>        if (r) {
> >
>