[PATCH v2] drm/amdkfd: Fix instruction hazard in gfx12 trap handler
Lancelot SIX
Lancelot.Six at amd.com
Tue Mar 11 21:56:20 UTC 2025
On 07/02/2025 23:38, Jay Cornwall wrote:
> VALU instructions with SGPR source need wait states to avoid hazard
> with SALU using different SGPR.
>
> v2: Eliminate some hazards to reduce code explosion
>
> Signed-off-by: Jay Cornwall <jay.cornwall at amd.com>
> Cc: Lancelot Six <lancelot.six at amd.com>
Hi,
That looks good to me, thanks. Sorry for the long delay to review.
Reviewed-by: Lancelot Six <lancelot.six at amd.com>
Best,
Lancelot.
> ---
> .../gpu/drm/amd/amdkfd/cwsr_trap_handler.h | 677 ++++++++++--------
> .../amd/amdkfd/cwsr_trap_handler_gfx12.asm | 82 ++-
> 2 files changed, 404 insertions(+), 355 deletions(-
More information about the amd-gfx
mailing list