[PATCH] drm/amd/display: add proper error message for vblank init

Mario Limonciello mario.limonciello at amd.com
Fri Mar 21 14:10:54 UTC 2025


On 3/21/2025 06:37, Saleemkhan Jamadar wrote:
> Update message to identifiy the vblank initialization fail case
> 
> Signed-off-by: Saleemkhan Jamadar <saleemkhan.jamadar at amd.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 8dd9bf58eac5..3decf1973c7d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -2218,7 +2218,7 @@ static int amdgpu_dm_init(struct amdgpu_device *adev)
>   
>   	if (drm_vblank_init(adev_to_drm(adev), adev->dm.display_indexes_num)) {
>   		DRM_ERROR(
> -		"amdgpu: failed to initialize sw for display support.\n");
> +		"amdgpu: failed to initialize vblank sw for display support.\n");
>   		goto error;
>   	}
>   

While touching this could you please swap away from DRM_ERROR() to 
drm_err()?


More information about the amd-gfx mailing list