[PATCH] drm/amdgpu: remove the duplicated mes queue deactivation setting

Liang, Prike Prike.Liang at amd.com
Fri Mar 28 11:41:48 UTC 2025


[Public]

There requires a similar change on the userq resume, and a new patch will include the change.

Regards,
      Prike

> -----Original Message-----
> From: Liang, Prike <Prike.Liang at amd.com>
> Sent: Friday, March 28, 2025 6:46 PM
> To: amd-gfx at lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Liang, Prike
> <Prike.Liang at amd.com>
> Subject: [PATCH] drm/amdgpu: remove the duplicated mes queue deactivation
> setting
>
> The MES queue deactivation status is already set in mes_userq_unmap(), so the
> caller needn't set the queue_active bit again.
>
> Signed-off-by: Prike Liang <Prike.Liang at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/mes_userqueue.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> index b469b800119f..3669934e6e17 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mes_userqueue.c
> @@ -358,10 +358,8 @@ mes_userq_mqd_destroy(struct amdgpu_userq_mgr
> *uq_mgr,  static int mes_userq_suspend(struct amdgpu_userq_mgr *uq_mgr,
>                                  struct amdgpu_usermode_queue *queue)  {
> -     if (queue->queue_active) {
> +     if (queue->queue_active)
>               mes_userq_unmap(uq_mgr, queue);
> -             queue->queue_active = false;
> -     }
>
>       return 0;
>  }
> --
> 2.34.1



More information about the amd-gfx mailing list