[PATCH V8 24/43] drm/amd/display: Skip color pipeline initialization for cursor plane

Shengyu Qu wiagn233 at outlook.com
Sun Mar 30 12:59:44 UTC 2025


Hi,

Do we really need to disable cursor plane color pipeline support? I 
don't think we need to disable that if it is supported, since there 
might be some user-defined colored cursor icon.

Best regards,
Shengyu

For some unknown reason, seems my mail is not shown in the mail list 
archive, so I resent it.

在 2025/3/27 7:47, Alex Hung 写道:
> cursor plane does not need to have color pipeline.
> 
> Signed-off-by: Alex Hung <alex.hung at amd.com>
> ---
> v7:
>   - Add a commit messages
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> index 9632b8b73e7e..b5b9b0b5da63 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_plane.c
> @@ -1792,6 +1792,9 @@ dm_plane_init_colorops(struct drm_plane *plane)
>   	struct drm_prop_enum_list pipelines[MAX_COLOR_PIPELINES];
>   	int len = 0;
>   
> +	if (plane->type == DRM_PLANE_TYPE_CURSOR)
> +		return 0;
> +
>   	/* Create COLOR_PIPELINE property and attach */
>   	drm_plane_create_color_pipeline_property(plane, pipelines, len);
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_0xE3520CC91929C8E7.asc
Type: application/pgp-keys
Size: 6868 bytes
Desc: OpenPGP public key
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20250330/02ee1c50/attachment-0001.key>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: OpenPGP_signature.asc
Type: application/pgp-signature
Size: 840 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20250330/02ee1c50/attachment-0001.sig>


More information about the amd-gfx mailing list