questions about smu_mode2_reset_is_support and smu_v13_0_init_display_count
Dr. David Alan Gilbert
linux at treblig.org
Wed May 7 00:32:10 UTC 2025
Hi,
I noticed two functions that are unused but I wasn't sure what to
do with them:
smu_v13_0_init_display_count() isn't called/wired up, where as the
v11 version is wired up:
drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
3574: .init_display_count = smu_v11_0_init_display_count,
so is v13 really unused or should it be wired up in a similar way?
secondly, smu_mode2_reset_is_support() is uncalled, but it's
the only caller through the mode2_reset_is_support() function
pointer; so if smu_mode2_reset_is_support() was deleted, does
it then make sense to clean up all of
sienna_cichlid_is_mode2_reset_supported,
aldebaran_is_mode2_reset_supported,
smu_v13_0_6_is_mode2_reset_supported
which that function pointer is sett to.
Thanks in advance,
Dave
--
-----Open up your eyes, open up your mind, open up your code -------
/ Dr. David Alan Gilbert | Running GNU/Linux | Happy \
\ dave @ treblig.org | | In Hex /
\ _________________________|_____ http://www.treblig.org |_______/
More information about the amd-gfx
mailing list