[PATCH] drm/amdkfd: drop warning in event_interrupt_isr_v1*()

[Alex Deucher]

Ping?

Alex

On Wed, May 7, 2025 at 10:07 AM Alex Deucher <alexander.deucher at amd.com> wrote:
>
> Commit ded8b3c36f17 ("drm/amdgpu: properly handle GC vs MM in amdgpu_vmid_mgr_init()")
> enables all 16 vmids for MMHUB on GC 10 and newer for KGD since
> there are no KFD resources using MMHUB.  With this change, KFD
> starts seeing MMHUB vmids in it's range with no pasid set.  As
> such there is no need to warn, we can just ignore those interrupts.
>
> Fixes: ded8b3c36f17 ("drm/amdgpu: properly handle GC vs MM in amdgpu_vmid_mgr_init()")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c | 3 +--
>  drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c | 3 +--
>  2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> index 54870b4c50000..3e1ad89747979 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v10.c
> @@ -175,8 +175,7 @@ static bool event_interrupt_isr_v10(struct kfd_node *dev,
>                 data[0], data[1], data[2], data[3], data[4], data[5], data[6],
>                 data[7]);
>
> -       /* If there is no valid PASID, it's likely a bug */
> -       if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
> +       if (pasid == 0)
>                 return 0;
>
>         /* Interrupt types we care about: various signals and faults.
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> index eb88ba8d8b012..2788a52714d10 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_int_process_v11.c
> @@ -287,8 +287,7 @@ static bool event_interrupt_isr_v11(struct kfd_node *dev,
>                 data[0], data[1], data[2], data[3], data[4], data[5], data[6],
>                 data[7]);
>
> -       /* If there is no valid PASID, it's likely a bug */
> -       if (WARN_ONCE(pasid == 0, "Bug: No PASID in KFD interrupt"))
> +       if (pasid == 0)
>                 return false;
>
>         /* Interrupt types we care about: various signals and faults.
> --
> 2.49.0
>