[PATCH 1/3] drm/amdgpu: seq64 memory unmap uses uninterruptible lock

[Christian König]

On 5/14/25 19:10, Philip Yang wrote:
> To unmap and free seq64 memory when drm node close to free vm, if there
> is signal accepted, then taking vm lock failed and leaking seq64 va
> mapping, and then dmesg has error log "still active bo inside vm".
> 
> Change to use uninterruptible lock fix the mapping leaking and no dmesg
> error log.
> 
> Signed-off-by: Philip Yang <Philip.Yang at amd.com>

I'm not 100% sure but I think I've seen the same patch from Arun before. So don't be surprised if that is already fixed on amd-stangin-drm-next.

Anyway feel free to add Reviewed-by: Christian König <christian.koenig at amd.com> and push to amd-staging-drm-next since that change is certainly correct.

Regards,
Christian.

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> index 3939761be31c..d45ebfb642ca 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_seq64.c
> @@ -139,7 +139,7 @@ void amdgpu_seq64_unmap(struct amdgpu_device *adev, struct amdgpu_fpriv *fpriv)
>  
>  	vm = &fpriv->vm;
>  
> -	drm_exec_init(&exec, DRM_EXEC_INTERRUPTIBLE_WAIT, 0);
> +	drm_exec_init(&exec, 0, 0);
>  	drm_exec_until_all_locked(&exec) {
>  		r = amdgpu_vm_lock_pd(vm, &exec, 0);
>  		if (likely(!r))