[PATCH] Revert "drm/amd/display: pause the workload setting in dm"

[Feng, Kenneth]

[AMD Official Use Only - AMD Internal Distribution Only]

Will figure out another way to fix the MALL idle power issue previously.
Reviewed-by: Kenneth Feng <kenneth.feng at amd.com>


-----Original Message-----
From: Alex Deucher <alexdeucher at gmail.com>
Sent: Thursday, May 22, 2025 1:47 AM
To: Zuo, Jerry <Jerry.Zuo at amd.com>
Cc: amd-gfx at lists.freedesktop.org; Feng, Kenneth <Kenneth.Feng at amd.com>
Subject: Re: [PATCH] Revert "drm/amd/display: pause the workload setting in dm"

Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.


On Wed, May 21, 2025 at 1:12 PM Fangzhi Zuo <Jerry.Zuo at amd.com> wrote:
>
> This reverts commit 243678df7a058f65f5f43e8026b359bcc91e0b69.
>
> Reason for revert: cause corruption on Dell U3224KB DP2 display.

Missing your signed-off-by.  Reverting this could result in higher power usage because I think the display idle state requires the default profile.

Acked-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c    | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> index e8bdd7f0c460..87058271b00c 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_crtc.c
> @@ -246,8 +246,6 @@ static void amdgpu_dm_crtc_vblank_control_worker(struct work_struct *work)
>         struct vblank_control_work *vblank_work =
>                 container_of(work, struct vblank_control_work, work);
>         struct amdgpu_display_manager *dm = vblank_work->dm;
> -       struct amdgpu_device *adev = drm_to_adev(dm->ddev);
> -       int r;
>
>         mutex_lock(&dm->dc_lock);
>
> @@ -275,15 +273,8 @@ static void amdgpu_dm_crtc_vblank_control_worker(struct work_struct *work)
>                         vblank_work->acrtc->dm_irq_params.allow_sr_entry);
>         }
>
> -       if (dm->active_vblank_irq_count == 0) {
> -               r = amdgpu_dpm_pause_power_profile(adev, true);
> -               if (r)
> -                       dev_warn(adev->dev, "failed to set default power profile mode\n");
> +       if (dm->active_vblank_irq_count == 0)
>                 dc_allow_idle_optimizations(dm->dc, true);
> -               r = amdgpu_dpm_pause_power_profile(adev, false);
> -               if (r)
> -                       dev_warn(adev->dev, "failed to restore the power profile mode\n");
> -       }
>
>         mutex_unlock(&dm->dc_lock);
>
> --
> 2.43.0
>