<html> <head> <meta content="text/html; charset=utf-8" http-equiv="Content-Type"> </head> <body text="#000000" bgcolor="#FFFFFF"> <div class="moz-cite-prefix">Please use the bool type and true/false for use_bank. Apart from that the patch looks like the right approach to me.<br> <br> BTW: On public mailing lists we usually use inline patches for reviews.<br> <br> Regards,<br> Christian.<br> <br> Am 27.06.2016 um 18:32 schrieb StDenis, Tom:<br> </div> <blockquote cite="mid:SN1PR12MB0784B4888712333AB0CA1BFFF7210@SN1PR12MB0784.namprd12.prod.outlook.com" type="cite"> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <style type="text/css" style="display:none;"></style> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>This adds the ability to select SH/SE banks in the debugfs entry.</p> <p><br> </p> <p>In concert with the other patch I sent out this morning (the config debugfs entry) the debug tool can now select banks and sanity check user input.</p> <p><br> </p> <p>Tom</p> </div> <br> <fieldset class="mimeAttachmentHeader"></fieldset> <br> <pre wrap="">_______________________________________________ amd-gfx mailing list <a class="moz-txt-link-abbreviated" href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a> <a class="moz-txt-link-freetext" href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </pre> </blockquote> <br> </body> </html>