<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>Yup I ended up adding instance to select_se_sh and then threw 0xFFFFFFFF all over gfx 7/8 as "broadcast".</p> <p><br> </p> <p>I have 3 patches waiting review :-)</p> <p><br> </p> <p>Tom</p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Wednesday, June 29, 2016 09:43<br> <b>To:</b> StDenis, Tom; Nicolai Hähnle; amd-gfx list<br> <b>Subject:</b> RE: GFX bank selection in MMIO regs debugfs entry</font> <div> </div> </div> <div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">You can just add instance as an argument.</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Alex</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] <b>On Behalf Of </b>StDenis, Tom<br> <b>Sent:</b> Tuesday, June 28, 2016 9:52 AM<br> <b>To:</b> Nicolai Hähnle; amd-gfx list<br> <b>Subject:</b> Re: GFX bank selection in MMIO regs debugfs entry</span></p> </div> </div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Hi Nicolai,</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Sure v2 of the patch could add that (this is why I haven't pushed the debugger changes either hehehe).</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Is there an amdgpu_*() interface to select the instance? Or should we submit a patch to augment select_se_sh?</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Tom</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <div> <div align="center" style="text-align: center; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> Nicolai Hähnle <<a href="mailto:nhaehnle@gmail.com" style="color: blue; text-decoration: underline;">nhaehnle@gmail.com</a>><br> <b>Sent:</b> Tuesday, June 28, 2016 08:54<br> <b>To:</b> StDenis, Tom; amd-gfx list<br> <b>Subject:</b> Re: GFX bank selection in MMIO regs debugfs entry</span><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> </div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-size:10.0pt; font-family:"Calibri","sans-serif"; color:black">On 27.06.2016 18:32, StDenis, Tom wrote:<br> > This adds the ability to select SH/SE banks in the debugfs entry.<br> <br> I know the existing amdgpu_gfx_select_se_sh only has SE and SH as the <br> name implies, but the GRBM_GFX_INDEX also has an instance field. It <br> would be good to account for that already, since this is defining a <br> somewhat public interface.<br> <br> Nicolai<br> <br> ><br> ><br> > In concert with the other patch I sent out this morning (the config<br> > debugfs entry) the debug tool can now select banks and sanity check user<br> > input.<br> ><br> ><br> > Tom<br> ><br> ><br> ><br> > _______________________________________________<br> > amd-gfx mailing list<br> > <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;"> amd-gfx@lists.freedesktop.org</a><br> > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk737986" style="color: blue; text-decoration: underline;"> https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><br> ></span></p> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>