<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <meta content="text/html; charset=UTF-8"> <style type="text/css" style="">  </style> <div dir="ltr"> <div id="x_divtagdefaultwrapper" style="font-size:12pt; color:#000000; background-color:#FFFFFF; font-family:Calibri,Arial,Helvetica,sans-serif"> Sure. Thanks Alex and Alexandre. Best Regards Rex </div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr">From: Alex Deucher <alexdeucher@gmail.com> Sent: Thursday, July 7, 2016 10:27:33 PM To: Zhu, Rex Cc: amd-gfx list Subject: Re: [PATCH 5/6] drm/amd/powerplay: add mvdd dpm support. <div> </div> </div> </div> <div class="PlainText">On Tue, Jul 5, 2016 at 5:48 AM, Rex Zhu <Rex.Zhu@amd.com> wrote: > SMC requires master switch bit to be se. > > Signed-off-by: Rex Zhu <Rex.Zhu@amd.com> > > Change-Id: I2f5fa89934c97c43885d5b0e09b3199981370067 With the s/be se/be set/ change mentioned by Alexandre fixed, the patch is: Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > index 2a71262..46f91b3 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/polaris10_hwmgr.c > @@ -1938,9 +1938,8 @@ static int polaris10_populate_vr_config(struct pp_hwmgr *hwmgr, > if (POLARIS10_VOLTAGE_CONTROL_BY_SVID2 == data->mvdd_control) { > config = VR_SVI2_PLANE_2; > table->VRConfig |= (config << VRCONF_MVDD_SHIFT); > - } else if (POLARIS10_VOLTAGE_CONTROL_BY_GPIO == data->mvdd_control) { > - config = VR_SMIO_PATTERN_2; > - table->VRConfig |= (config << VRCONF_MVDD_SHIFT); > + cgs_write_ind_register(hwmgr->device, CGS_IND_REG__SMC, data->soft_regs_start + > + offsetof(SMU74_SoftRegisters, AllowMvddSwitch), 0x1); > } else { > config = VR_STATIC_VOLTAGE; > table->VRConfig |= (config << VRCONF_MVDD_SHIFT); > -- > 1.9.1 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a> </div> </body> </html>