<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;">
<p>Entire series looks fine with the exception of patch #7 I'd remove the redundant parenthesis e.g.</p>
<p><br>
</p>
<p><span style="color: rgb(33, 33, 33); font-size: 13.3333px;">- if ((force_high == false) && (cz_ps->action == FORCE_HIGH))</span><br style="color: rgb(33, 33, 33); font-size: 13.3333px;">
<span style="color: rgb(33, 33, 33); font-size: 13.3333px;">+ if (!(force_high) && (cz_ps->action == FORCE_HIGH))</span><br>
</p>
<div><br>
</div>
(and in various places). With that
<div><br>
</div>
<div>Reviewed-by: Tom St Denis <tom.stdenis@amd.com>. </div>
<div><br>
</div>
<div>The PP changes (patch #8) looks fine but I wonder if they had intended to put more error checking in at some point.</div>
<div><br>
</div>
<div>Tom<br>
<br>
<div style="color: rgb(0, 0, 0);">
<div>
<hr tabindex="-1" style="display:inline-block; width:98%">
<div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Edward O'Callaghan <funfunctor@folklore1984.net><br>
<b>Sent:</b> Monday, July 11, 2016 03:11<br>
<b>To:</b> amd-gfx@lists.freedesktop.org<br>
<b>Cc:</b> StDenis, Tom; alexandre.f.demers@gmail.com<br>
<b>Subject:</b> [PATCH 1/8] drivers/amdgpu: Remove spurious semicolons</font>
<div> </div>
</div>
</div>
<font size="2"><span style="font-size:10pt;">
<div class="PlainText">Found-by: Coccinelle<br>
Signed-off-by: Edward O'Callaghan <funfunctor@folklore1984.net><br>
---<br>
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-<br>
drivers/gpu/drm/amd/amdgpu/fiji_smc.c | 2 +-<br>
drivers/gpu/drm/amd/amdgpu/iceland_smc.c | 2 +-<br>
drivers/gpu/drm/amd/amdgpu/tonga_smc.c | 2 +-<br>
4 files changed, 4 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c<br>
index b0832da..f518c10 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c<br>
@@ -122,7 +122,7 @@ static void amdgpu_flip_work_func(struct work_struct *__work)<br>
spin_unlock_irqrestore(&crtc->dev->event_lock, flags);<br>
usleep_range(min_udelay, 2 * min_udelay);<br>
spin_lock_irqsave(&crtc->dev->event_lock, flags);<br>
- };<br>
+ }<br>
<br>
if (!repcnt)<br>
DRM_DEBUG_DRIVER("Delay problem on crtc %d: min_udelay %d, "<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/fiji_smc.c b/drivers/gpu/drm/amd/amdgpu/fiji_smc.c<br>
index b336c91..b3e19ba 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/fiji_smc.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/fiji_smc.c<br>
@@ -173,7 +173,7 @@ static int fiji_send_msg_to_smc(struct amdgpu_device *adev, PPSMC_Msg msg)<br>
{<br>
if (!fiji_is_smc_ram_running(adev))<br>
{<br>
- return -EINVAL;;<br>
+ return -EINVAL;<br>
}<br>
<br>
if (wait_smu_response(adev)) {<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c<br>
index 52ee081..7a0f0e6 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/iceland_smc.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/iceland_smc.c<br>
@@ -211,7 +211,7 @@ static int iceland_send_msg_to_smc_without_waiting(struct amdgpu_device *adev,<br>
PPSMC_Msg msg)<br>
{<br>
if (!iceland_is_smc_ram_running(adev))<br>
- return -EINVAL;;<br>
+ return -EINVAL;<br>
<br>
if (wait_smu_response(adev)) {<br>
DRM_ERROR("Failed to send previous message\n");<br>
diff --git a/drivers/gpu/drm/amd/amdgpu/tonga_smc.c b/drivers/gpu/drm/amd/amdgpu/tonga_smc.c<br>
index 083893d..940de18 100644<br>
--- a/drivers/gpu/drm/amd/amdgpu/tonga_smc.c<br>
+++ b/drivers/gpu/drm/amd/amdgpu/tonga_smc.c<br>
@@ -173,7 +173,7 @@ static int tonga_send_msg_to_smc(struct amdgpu_device *adev, PPSMC_Msg msg)<br>
{<br>
if (!tonga_is_smc_ram_running(adev))<br>
{<br>
- return -EINVAL;;<br>
+ return -EINVAL;<br>
}<br>
<br>
if (wait_smu_response(adev)) {<br>
-- <br>
2.7.4<br>
<br>
</div>
</span></font></div>
</div>
</div>
</body>
</html>