<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 14 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple"> <div class="WordSection1"> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Presumably? It generally seems to work. There is no formal structure. The jump tables are part of the actual firmware image and are restored from the buffer on ungate when the srams are powered back up. <o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Alex<o:p></o:p></span></p> <p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> StDenis, Tom <br> <b>Sent:</b> Friday, July 15, 2016 1:00 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Do we know for a fact the jump tables are being initialized properly? They're only used on CZ/ST with PG turned on so it's entirely possible that code is buggy.<o:p></o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">I don't like the aliasing the structs in amdgpu_ucode.h to random binary data specially since they have no packed pragma's attached. We should either deserialize the firmware properly (implicitly load the struct members) or add a pragma.<o:p></o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Tom<o:p></o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <div class="MsoNormal" align="center" style="text-align:center;background:white"> <span style="font-family:"Calibri","sans-serif";color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="divRplyFwdMsg"> <p class="MsoNormal" style="background:white"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com">Tom.StDenis@amd.com</a>><br> <b>Sent:</b> Friday, July 15, 2016 12:25<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</span><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal" style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> </div> </div> <div> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black">Reviewed-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com">tom.stdenis@amd.com</a>><o:p></o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <p class="MsoNormal" style="margin-bottom:12.0pt;background:white"><span style="font-family:"Calibri","sans-serif";color:black"><o:p> </o:p></span></p> <div> <div> <div class="MsoNormal" align="center" style="text-align:center;background:white"> <span style="font-family:"Calibri","sans-serif";color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p class="MsoNormal" style="background:white"><b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black">From:</span></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Alex Deucher <<a href="mailto:alexdeucher@gmail.com">alexdeucher@gmail.com</a>><br> <b>Sent:</b> Friday, July 15, 2016 12:08<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</span><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> <div> <p class="MsoNormal" style="background:white"><span style="font-family:"Calibri","sans-serif";color:black"> <o:p></o:p></span></p> </div> </div> </div> <div> <p class="MsoNormal" style="background:white"><span style="font-size:10.0pt;font-family:"Calibri","sans-serif";color:black">Still some stability issues under certain workloads.<br> <br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com">alexander.deucher@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/vi.c | 14 --------------<br> 1 file changed, 14 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c<br> index cda7def..03a31c5 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br> @@ -1249,15 +1249,7 @@ static int vi_common_early_init(void *handle)<br> AMD_CG_SUPPORT_HDP_LS |<br> AMD_CG_SUPPORT_SDMA_MGCG |<br> AMD_CG_SUPPORT_SDMA_LS;<br> - /* rev0 hardware doesn't support PG */<br> adev->pg_flags = 0;<br> - if (adev->rev_id != 0x00)<br> - adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br> - AMD_PG_SUPPORT_GFX_SMG |<br> - AMD_PG_SUPPORT_GFX_DMG |<br> - AMD_PG_SUPPORT_CP |<br> - AMD_PG_SUPPORT_RLC_SMU_HS |<br> - AMD_PG_SUPPORT_GFX_PIPELINE;<br> adev->external_rev_id = adev->rev_id + 0x1;<br> break;<br> case CHIP_STONEY:<br> @@ -1276,12 +1268,6 @@ static int vi_common_early_init(void *handle)<br> AMD_CG_SUPPORT_HDP_LS |<br> AMD_CG_SUPPORT_SDMA_MGCG |<br> AMD_CG_SUPPORT_SDMA_LS;<br> - adev->pg_flags = AMD_PG_SUPPORT_GFX_PG |<br> - AMD_PG_SUPPORT_GFX_SMG |<br> - AMD_PG_SUPPORT_GFX_DMG |<br> - AMD_PG_SUPPORT_GFX_PIPELINE |<br> - AMD_PG_SUPPORT_CP |<br> - AMD_PG_SUPPORT_RLC_SMU_HS;<br> adev->external_rev_id = adev->rev_id + 0x1;<br> break;<br> default:<br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk768356">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a><o:p></o:p></span></p> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>