<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;background-color:#FFFFFF;font-family:Calibri,Arial,Helvetica,sans-serif;"> <p>The <span>mmRLC_JUMP_TABLE_RESTORE isn't written unless you have PG enabled so the code has been there but I don't think it's really been exercised until now.</span></p> <p><span><br> </span></p> <p><span>Oddly enough I'm able to read <span>mmRLC_PG_ALWAYS_ON_CU_MASK and it comes back as 0x3 despite not being written to. Is that a golden value or the value the hardware gives out of reset (on a Stoney)?</span></span></p> <p><span><span><br> </span></span></p> <p><span><span>Tom</span></span></p> <br> <br> <div style="color: rgb(0, 0, 0);"> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Deucher, Alexander<br> <b>Sent:</b> Friday, July 15, 2016 13:18<br> <b>To:</b> StDenis, Tom; amd-gfx@lists.freedesktop.org<br> <b>Subject:</b> RE: [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</font> <div> </div> </div> <div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Presumably? It generally seems to work. There is no formal structure. The jump tables are part of the actual firmware image and are restored from the buffer on ungate when the srams are powered back up. </span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D">Alex</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:#1F497D"> </span></p> <div style="border:none; border-left:solid blue 1.5pt; padding:0in 0in 0in 4.0pt"> <div> <div style="border:none; border-top:solid #B5C4DF 1.0pt; padding:3.0pt 0in 0in 0in"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> <b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt; font-family:"Tahoma","sans-serif""> StDenis, Tom <br> <b>Sent:</b> Friday, July 15, 2016 1:00 PM<br> <b>To:</b> amd-gfx@lists.freedesktop.org<br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</span></p> </div> </div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif;"> </p> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Do we know for a fact the jump tables are being initialized properly? They're only used on CZ/ST with PG turned on so it's entirely possible that code is buggy.</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">I don't like the aliasing the structs in amdgpu_ucode.h to random binary data specially since they have no packed pragma's attached. We should either deserialize the firmware properly (implicitly load the struct members) or add a pragma.</span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Tom</span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <div align="center" style="text-align: center; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="divRplyFwdMsg"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" style="color: blue; text-decoration: underline;">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of StDenis, Tom <<a href="mailto:Tom.StDenis@amd.com" style="color: blue; text-decoration: underline;">Tom.StDenis@amd.com</a>><br> <b>Sent:</b> Friday, July 15, 2016 12:25<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> Re: [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</span><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> <div> <div id="divtagdefaultwrapper"> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black">Reviewed-by: Tom St Denis <<a href="mailto:tom.stdenis@amd.com" style="color: blue; text-decoration: underline;">tom.stdenis@amd.com</a>></span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="background:white"><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <div> <div align="center" style="text-align: center; margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> <hr size="2" width="98%" align="center"> </span></div> <div id="x_divRplyFwdMsg"> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black">From:</span></b><span style="font-size:11.0pt; font-family:"Calibri","sans-serif"; color:black"> amd-gfx <<a href="mailto:amd-gfx-bounces@lists.freedesktop.org" style="color: blue; text-decoration: underline;">amd-gfx-bounces@lists.freedesktop.org</a>> on behalf of Alex Deucher <<a href="mailto:alexdeucher@gmail.com" style="color: blue; text-decoration: underline;">alexdeucher@gmail.com</a>><br> <b>Sent:</b> Friday, July 15, 2016 12:08<br> <b>To:</b> <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;"> amd-gfx@lists.freedesktop.org</a><br> <b>Cc:</b> Deucher, Alexander<br> <b>Subject:</b> [PATCH] drm/amdgpu: disable GFX PG on CZ/BR/ST</span><span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-family:"Calibri","sans-serif"; color:black"> </span></p> </div> </div> </div> <div> <p style="margin: 0in 0in 0.0001pt; font-size: 12pt; font-family: "Times New Roman", serif; background: white;"> <span style="font-size:10.0pt; font-family:"Calibri","sans-serif"; color:black">Still some stability issues under certain workloads.<br> <br> Signed-off-by: Alex Deucher <<a href="mailto:alexander.deucher@amd.com" style="color: blue; text-decoration: underline;">alexander.deucher@amd.com</a>><br> ---<br> drivers/gpu/drm/amd/amdgpu/vi.c | 14 --------------<br> 1 file changed, 14 deletions(-)<br> <br> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c<br> index cda7def..03a31c5 100644<br> --- a/drivers/gpu/drm/amd/amdgpu/vi.c<br> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c<br> @@ -1249,15 +1249,7 @@ static int vi_common_early_init(void *handle)<br> AMD_CG_SUPPORT_HDP_LS |<br> AMD_CG_SUPPORT_SDMA_MGCG |<br> AMD_CG_SUPPORT_SDMA_LS;<br> - /* rev0 hardware doesn't support PG */<br> adev->pg_flags = 0;<br> - if (adev->rev_id != 0x00)<br> - adev->pg_flags |= AMD_PG_SUPPORT_GFX_PG |<br> - AMD_PG_SUPPORT_GFX_SMG |<br> - AMD_PG_SUPPORT_GFX_DMG |<br> - AMD_PG_SUPPORT_CP |<br> - AMD_PG_SUPPORT_RLC_SMU_HS |<br> - AMD_PG_SUPPORT_GFX_PIPELINE;<br> adev->external_rev_id = adev->rev_id + 0x1;<br> break;<br> case CHIP_STONEY:<br> @@ -1276,12 +1268,6 @@ static int vi_common_early_init(void *handle)<br> AMD_CG_SUPPORT_HDP_LS |<br> AMD_CG_SUPPORT_SDMA_MGCG |<br> AMD_CG_SUPPORT_SDMA_LS;<br> - adev->pg_flags = AMD_PG_SUPPORT_GFX_PG |<br> - AMD_PG_SUPPORT_GFX_SMG |<br> - AMD_PG_SUPPORT_GFX_DMG |<br> - AMD_PG_SUPPORT_GFX_PIPELINE |<br> - AMD_PG_SUPPORT_CP |<br> - AMD_PG_SUPPORT_RLC_SMU_HS;<br> adev->external_rev_id = adev->rev_id + 0x1;<br> break;<br> default:<br> -- <br> 2.5.5<br> <br> _______________________________________________<br> amd-gfx mailing list<br> <a href="mailto:amd-gfx@lists.freedesktop.org" style="color: blue; text-decoration: underline;">amd-gfx@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/amd-gfx" id="LPlnk768356" style="color: blue; text-decoration: underline;">https://lists.freedesktop.org/mailman/listinfo/amd-gfx</a></span></p> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </div> </body> </html>